From: Joonsoo Kim <js1304@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-team@lge.com, Vlastimil Babka <vbabka@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
Roman Gushchin <guro@fb.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH v4 05/11] mm/migrate: clear __GFP_RECLAIM for THP allocation for migration
Date: Thu, 9 Jul 2020 12:26:30 +0900 [thread overview]
Message-ID: <CAAmzW4PdjSa0qO3EJwCEBTrLyCpCXKSZbV1b-ptPORDKqO4AvA@mail.gmail.com> (raw)
In-Reply-To: <20200708074820.GE7271@dhcp22.suse.cz>
2020년 7월 8일 (수) 오후 4:48, Michal Hocko <mhocko@kernel.org>님이 작성:
>
> On Wed 08-07-20 16:19:17, Joonsoo Kim wrote:
> > On Tue, Jul 07, 2020 at 01:40:19PM +0200, Michal Hocko wrote:
> [...]
> > Subject: [PATCH] mm/migrate: clear __GFP_RECLAIM for THP allocation for
> > migration
> >
> > In migration target allocation functions, THP allocations uses different
> > gfp_mask, especially, in regard to the reclaim gfp_mask. There is no
> > reason to use different reclaim gfp_mask for each cases and it is
> > an obstacle to make a common function in order to clean-up migration
> > target allocation functions. This patch fixes this situation by using
> > common reclaim gfp_mask for THP allocation.
>
> I would find the following more understandable, feel free to reuse parts
> that you like:
> "
> new_page_nodemask is a migration callback and it tries to use a common
> gfp flags for the target page allocation whether it is a base page or a
> THP. The later only adds GFP_TRANSHUGE to the given mask. This results
> in the allocation being slightly more aggressive than necessary because
> the resulting gfp mask will contain also __GFP_RECLAIM_KSWAPD. THP
> allocations usually exclude this flag to reduce over eager background
> reclaim during a high THP allocation load which has been seen during
> large mmaps initialization. There is no indication that this is a
> problem for migration as well but theoretically the same might happen
> when migrating large mappings to a different node. Make the migration
> callback consistent with regular THP allocations.
> "
Looks good!
I will use this description.
Thanks.
next prev parent reply other threads:[~2020-07-09 3:26 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 7:44 [PATCH v4 00/11] clean-up the migration target allocation functions js1304
2020-07-07 7:44 ` [PATCH v4 01/11] mm/page_isolation: prefer the node of the source page js1304
2020-07-07 7:44 ` [PATCH v4 02/11] mm/migrate: move migration helper from .h to .c js1304
2020-07-07 7:44 ` [PATCH v4 03/11] mm/hugetlb: unify migration callbacks js1304
2020-07-07 11:05 ` Vlastimil Babka
2020-07-07 11:19 ` Michal Hocko
2020-07-07 7:44 ` [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware js1304
2020-07-07 11:22 ` Vlastimil Babka
2020-07-08 7:16 ` Joonsoo Kim
2020-07-08 7:41 ` Michal Hocko
2020-07-08 9:26 ` Vlastimil Babka
2020-07-08 10:57 ` Aneesh Kumar K.V
2020-07-08 11:32 ` Michal Hocko
2020-07-09 6:43 ` Michal Hocko
2020-07-09 7:03 ` Joonsoo Kim
2020-07-09 0:27 ` Mike Kravetz
2020-07-07 11:31 ` Michal Hocko
2020-07-08 6:48 ` Michal Hocko
2020-07-08 7:12 ` Joonsoo Kim
2020-07-07 7:44 ` [PATCH v4 05/11] mm/migrate: clear __GFP_RECLAIM for THP allocation for migration js1304
2020-07-07 11:40 ` Michal Hocko
2020-07-08 7:19 ` Joonsoo Kim
2020-07-08 7:48 ` Michal Hocko
2020-07-09 3:26 ` Joonsoo Kim [this message]
2020-07-07 12:17 ` Vlastimil Babka
2020-07-08 7:17 ` Joonsoo Kim
2020-07-09 7:17 ` Joonsoo Kim
2020-07-07 7:44 ` [PATCH v4 06/11] mm/migrate: make a standard migration target allocation function js1304
2020-07-07 11:43 ` Michal Hocko
2020-07-07 14:49 ` Vlastimil Babka
2020-07-07 19:00 ` Michal Hocko
2020-07-09 7:15 ` Joonsoo Kim
2020-07-09 10:28 ` Michal Hocko
2020-07-07 7:44 ` [PATCH v4 07/11] mm/gup: use a standard migration target allocation callback js1304
2020-07-07 11:46 ` Michal Hocko
2020-07-08 7:21 ` Joonsoo Kim
2020-07-07 7:44 ` [PATCH v4 08/11] mm/mempolicy: " js1304
2020-07-07 7:44 ` [PATCH v4 09/11] mm/page_alloc: remove a wrapper for alloc_migration_target() js1304
2020-07-07 7:44 ` [PATCH v4 10/11] mm/memory-failure: " js1304
2020-07-07 11:48 ` Michal Hocko
2020-07-07 15:03 ` Vlastimil Babka
2020-07-07 18:55 ` Michal Hocko
2020-07-07 15:00 ` Vlastimil Babka
2020-07-07 7:44 ` [PATCH v4 11/11] mm/memory_hotplug: " js1304
2020-07-07 11:52 ` Michal Hocko
2020-07-07 15:09 ` Vlastimil Babka
2020-07-09 3:25 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAmzW4PdjSa0qO3EJwCEBTrLyCpCXKSZbV1b-ptPORDKqO4AvA@mail.gmail.com \
--to=js1304@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hch@infradead.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).