From: Arun Murthy <arunrmurthy.83@gmail.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: herbert@gondor.hengli.com.au, davem@davemloft.net,
linus.walleij@linaro.org, andreas.westin@stericsson.com,
rjw@sisk.pl, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/4] drivers/crypto/ux500/cryp/cryp_core.c: fix error return code
Date: Mon, 24 Sep 2012 17:31:55 +0530 [thread overview]
Message-ID: <CAAnUQp3g6hGo1m6yZG76ifGxpuQRzYBk51ZsaNAVkgYLwMhjZw@mail.gmail.com> (raw)
In-Reply-To: <1347902908-19006-1-git-send-email-peter.senna@gmail.com>
On Mon, Sep 17, 2012 at 10:58 PM, Peter Senna Tschudin
<peter.senna@gmail.com> wrote:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Reviewed-by: Arun Murthy <arunrmurthy83@gmail.com>
next prev parent reply other threads:[~2012-09-24 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 17:28 [PATCH 1/4] drivers/crypto/ux500/cryp/cryp_core.c: fix error return code Peter Senna Tschudin
2012-09-17 17:28 ` [PATCH 2/4] drivers/crypto/hifn_795x.c: " Peter Senna Tschudin
2012-09-17 17:28 ` [PATCH 3/4] drivers/crypto/amcc/crypto4xx_core.c: " Peter Senna Tschudin
2012-09-17 17:28 ` [PATCH 4/4] drivers/crypto/tegra-aes.c: " Peter Senna Tschudin
2012-09-24 12:01 ` Arun Murthy [this message]
2012-09-27 5:43 ` [PATCH 1/4] drivers/crypto/ux500/cryp/cryp_core.c: " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAnUQp3g6hGo1m6yZG76ifGxpuQRzYBk51ZsaNAVkgYLwMhjZw@mail.gmail.com \
--to=arunrmurthy.83@gmail.com \
--cc=andreas.westin@stericsson.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).