archive mirror
 help / color / mirror / Atom feed
From: Vaibhav Agarwal <>
To: Mark Greer <>
Cc: Alexandre Belloni <>,
	Johan Hovold <>, Alex Elder <>,
	Greg Kroah-Hartman <>,,,
Subject: Re: [PATCH] greybus: audio: remove unused code
Date: Thu, 14 May 2020 01:07:36 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, May 13, 2020 at 11:15 PM Mark Greer <> wrote:
> On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> > GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> > reported in September 2016, it depends on an "out-of-tree qualcomm audio
> > driver". This driver never made it upstream.
> >
> >
> >
> > Moreover, there doesn't seem to be any interest in actually fixing the
> > driver as it uses ASoC APIs that have been removed from the kernel in 2018
> > as shown by its use of snd_soc_register_codec and
> > snd_soc_codec_get_drvdata, removed in commit 999f7f5af8eb ("ASoC: remove
> > Codec related code").
> >
> > Signed-off-by: Alexandre Belloni <>
> > ---
Hi Alexandre,

As mentioned in the mail archive referred, the GB Codec driver that is
currently available in kernel tree is dependent on qualcomm audio
driver. And some time later I made some minor modifications to remove
the unnecessary dependencies. However, I missed to share the same with
the community :(

Thanks to you for triggering the thread. Now, I could retrieve my local
changes and I have been in the process of updating it again to make it
compatible with latest kernel.

I'm planning to share the same here in the next few days.  I'll mark you
in CC to seek your review comments as well.

In case, I'm unable to make those changes to the staging tree, I would
also recommend to drop this code. Kindly let me know your opinion.


> Everything you say is true but it is still kinda sad to see this go.
> But that is life...  If and when someone has the motivation to get this
> working again they can take a look at the git history.
> Thanks for this, Alexandre.
> Acked-by: Mark Greer <>

  reply	other threads:[~2020-05-13 19:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 21:29 [PATCH] greybus: audio: remove unused code Alexandre Belloni
2020-05-13 17:45 ` Mark Greer
2020-05-13 19:37   ` Vaibhav Agarwal [this message]
2020-05-15 13:44     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).