From: Moritz Fischer <moritz.fischer@ettus.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Alan Tull <atull@opensource.altera.com>,
"dinguyen@opensource.altera.com" <dinguyen@opensource.altera.com>,
linux-fpga@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge
Date: Sat, 3 Dec 2016 08:41:25 -0800 [thread overview]
Message-ID: <CAAtXAHdvWfRxDGNVa2Q=6uJ007r3Cg0wP8jwKwfS-xBe_q-NLQ@mail.gmail.com> (raw)
In-Reply-To: <20161202212305.19475-1-dinguyen@kernel.org>
On Fri, Dec 2, 2016 at 1:23 PM, Dinh Nguyen <dinguyen@kernel.org> wrote:
> Fix up these sparse warnings:
>
> drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not
> declared. Should it be static?
> drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was
> not declared. Should it be static?
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/fpga-bridge.c | 2 +-
> drivers/fpga/fpga-mgr.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
> index 33ee83e..e04a899 100644
> --- a/drivers/fpga/fpga-bridge.c
> +++ b/drivers/fpga/fpga-bridge.c
> @@ -27,7 +27,7 @@ static DEFINE_IDA(fpga_bridge_ida);
> static struct class *fpga_bridge_class;
>
> /* Lock for adding/removing bridges to linked lists*/
> -spinlock_t bridge_list_lock;
> +static spinlock_t bridge_list_lock;
>
> static int fpga_bridge_of_node_match(struct device *dev, const void *data)
> {
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index f0a69d3..32860dd 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -186,7 +186,7 @@ static struct attribute *fpga_mgr_attrs[] = {
> };
> ATTRIBUTE_GROUPS(fpga_mgr);
>
> -struct fpga_manager *__fpga_mgr_get(struct device *dev)
> +static struct fpga_manager *__fpga_mgr_get(struct device *dev)
> {
> struct fpga_manager *mgr;
> int ret = -ENODEV;
> --
> 2.8.3
>
Thanks,
Moritz
next prev parent reply other threads:[~2016-12-03 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 21:23 [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge Dinh Nguyen
2016-12-03 16:41 ` Moritz Fischer [this message]
2016-12-04 1:34 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAtXAHdvWfRxDGNVa2Q=6uJ007r3Cg0wP8jwKwfS-xBe_q-NLQ@mail.gmail.com' \
--to=moritz.fischer@ettus.com \
--cc=atull@opensource.altera.com \
--cc=dinguyen@kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).