linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Víctor Manuel Jáquez Leal" <vjaquez@igalia.com>,
	"Greg Kroah-Hartman" <gregkh@suse.de>,
	"Armando Uribe" <x0095078@ti.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-omap@vger.kernel.org, "Ernesto Ramos" <ernesto@ti.com>,
	"Rene Sapiens" <rene.sapiens@ti.com>
Subject: Re: [PATCH 2/5] staging: tidspbridge: remove unused header
Date: Mon, 30 Jan 2012 11:15:42 -0600	[thread overview]
Message-ID: <CAB-zwWjit=Qpt3PCW4fS0OEL_hw6=nLO0a9bemzj8eAEOFGBxw@mail.gmail.com> (raw)
In-Reply-To: <CAMP44s0YapTKw6tbz3mnYeBXu1Ut-fPahRNy8U3uSroo_zDWtA@mail.gmail.com>

2012/1/24 Felipe Contreras <felipe.contreras@gmail.com>:
> 2012/1/23 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>:
>> No functional changes.
>>
>> The header file drv_interface.h was only used locally, hence there's no need
>> to have it.
>>
>> Also the only prototyped functions were the file_operations callbacks, then
>> this commit moves them up to avoid prototyping too.
...
>
> But looks good to me either way.

FWIW, I agree.

Regards,

Omar

  reply	other threads:[~2012-01-30 17:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23 20:09 [PATCH 0/5] staging: tidspbridge: clean up drv_interface.c Víctor Manuel Jáquez Leal
2012-01-23 20:09 ` [PATCH 1/5] staging: tidspbridge: more readable code Víctor Manuel Jáquez Leal
2012-01-24 18:22   ` Felipe Contreras
2012-01-30 17:14     ` Ramirez Luna, Omar
2012-01-23 20:09 ` [PATCH 2/5] staging: tidspbridge: remove unused header Víctor Manuel Jáquez Leal
2012-01-24 17:45   ` Felipe Contreras
2012-01-30 17:15     ` Ramirez Luna, Omar [this message]
2012-01-23 20:09 ` [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c Víctor Manuel Jáquez Leal
2012-01-30 17:25   ` Ramirez Luna, Omar
2012-01-30 17:59     ` Víctor M. Jáquez L.
2012-01-30 19:29     ` Dan Carpenter
2012-01-30 19:53       ` Joe Perches
2012-01-30 20:33         ` Víctor M. Jáquez L.
2012-01-30 20:40           ` Joe Perches
2012-01-23 20:09 ` [PATCH 4/5] staging: tidspbridge: silence the compiler Víctor Manuel Jáquez Leal
2012-01-30 17:28   ` Ramirez Luna, Omar
2012-01-23 20:09 ` [PATCH 5/5] staging: tidspbridge: remove header inclusions Víctor Manuel Jáquez Leal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB-zwWjit=Qpt3PCW4fS0OEL_hw6=nLO0a9bemzj8eAEOFGBxw@mail.gmail.com' \
    --to=omar.ramirez@ti.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=ernesto@ti.com \
    --cc=felipe.contreras@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rene.sapiens@ti.com \
    --cc=vjaquez@igalia.com \
    --cc=x0095078@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).