From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F73C83004 for ; Wed, 29 Apr 2020 14:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3020E2082E for ; Wed, 29 Apr 2020 14:06:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="hRK69Fjp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728307AbgD2OGO (ORCPT ); Wed, 29 Apr 2020 10:06:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727820AbgD2OGN (ORCPT ); Wed, 29 Apr 2020 10:06:13 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D666C03C1AE for ; Wed, 29 Apr 2020 07:06:13 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id g4so2777142ljl.2 for ; Wed, 29 Apr 2020 07:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/5dFXvkHlFL4ZD9k3m+cudI2M3jreB1NrwloZ96EAJw=; b=hRK69FjpTSEspooL3pngL3RWCh2k42g9+qRkAdCL+irtc4FBd8usHLppdKZiUO37H4 dVtIaQds7wIJpD4FvJmA66WsFpFfircv+CumTEfc64ZSOaC04mVKNMUiibqxvwXKlthW uV/x8yUF7yTSwotvszuUAYM3u62kvRUPdUhak5B9N3l1WIRWV5MaiV84IC2e8djDPvwE Yr8AcLkIr1KWLn53YcTtBcJGoRPGQ1Pqr7OnW/qaqaIkm3e2ejq+sjpqgO3w+/wHVZQ8 3Jmoz2QNSIxgVhyhS7eHhnQ7OHVYaCMFrOcDADZh3gAbG5a3TT0Y72ntLo6SHcnf3IBB uj0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/5dFXvkHlFL4ZD9k3m+cudI2M3jreB1NrwloZ96EAJw=; b=X6GZMNtVuDOW7QweOXcrwxUp5FULAkDxQfx8EsLxdFbFU70I3ly09/qXJLQ9EMQw2f 4VQTPX8ihuH8zkm7rIMykqgFhA40ewHudr1mm9gq046A91TW+a3GvKkuET4yRCuDn9sD 0KGwBA+9ufgLEiwwUxwHpr1+xDZgtBbS/JGq63zMXjYSvdfzBTvGRb7B/A6g6yc6QJtg 8o0X9+V7LeUCS1iZQbK14Bac8LB1XuBntn13bF8hd1GGW236h5tUKpG/eLwrSvXpkO/i agsL9KkLpYfyMxfHEi4PIbdpz8hvQro8dWL8J3T2mfzgXyoPSdAUnugXb32neglBylkH +3Jw== X-Gm-Message-State: AGi0PuZHGGXZroakPtjP/V4gTf44wKJ7OO+a8K4uR92AC3NolALfQNVx lkt4vaSm5bbz+9q97z23edBiOxwpSRZtzjfnEcPN1g== X-Google-Smtp-Source: APiQypKeyYViSeG3LDYxj8g69kihbk0QRE6mRva/Grt1UgVyN/1ZIYYoZXAzChs4XfsXoPtgXgLAGZsvsvLk5MwjgfQ= X-Received: by 2002:a2e:8e98:: with SMTP id z24mr21704390ljk.134.1588169171856; Wed, 29 Apr 2020 07:06:11 -0700 (PDT) MIME-Version: 1.0 References: <20200427074222.65369-1-maco@android.com> <20200427170613.GA13686@lst.de> <20200428070200.GC18754@lst.de> In-Reply-To: From: Martijn Coenen Date: Wed, 29 Apr 2020 16:06:00 +0200 Message-ID: Subject: Re: [PATCH v3 0/9] Add a new LOOP_SET_FD_AND_STATUS ioctl To: Christoph Hellwig Cc: Jens Axboe , Ming Lei , Narayan Kamath , Zimuzo Ezeozue , kernel-team@android.com, linux-block , LKML , Martijn Coenen , Bart Van Assche , Chaitanya Kulkarni , Jaegeuk Kim Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 4:57 PM Martijn Coenen wrote: > and it allows requesting a partition scan. It makes sense to maintain > that behavior, but what about LO_FLAGS_DIRECT_IO? I think you're > proposing LOOP_SET_STATUS(64) should keep ignoring that like it used > to? I've just sent a v4 which basically implements that and your other suggestions. Thanks, Martijn > > Thanks, > Martijn > > > and then in the main function reject anything not known. > > > > And then maybe add something like 64 bytes of padding to the end of the > > new structure, so that we can use flags to expand to it.