From: Chris Chiu <chiu@endlessm.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: perex@perex.cz, tiwai@suse.com, Kailang <kailang@realtek.com>,
Hui Wang <hui.wang@canonical.com>,
tomas.espeleta@gmail.com, alsa-devel@alsa-project.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Upstreaming Team <linux@endlessm.com>,
Jian-Hong Pan <jian-hong@endlessm.com>
Subject: Re: [PATCH v2] ALSA: hda/realtek - Enable the bass speaker of ASUS UX431FLC
Date: Mon, 30 Dec 2019 11:12:46 +0800 [thread overview]
Message-ID: <CAB4CAwd=DNOqsRDEB5tRtN7yUgkM6fXi3yy5-PzW=3cCx=_45A@mail.gmail.com> (raw)
In-Reply-To: <s5h4kxk6fkh.wl-tiwai@suse.de>
On Sat, Dec 28, 2019 at 4:05 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Fri, 27 Dec 2019 11:08:25 +0100,
> Chris Chiu wrote:
> >
> > ASUS reported that there's an bass speaker in addition to internal
> > speaker and it uses DAC 0x02. It was not enabled in the commit
> > 436e25505f34 ("ALSA: hda/realtek - Enable internal speaker of ASUS
> > UX431FLC") which only enables the amplifier for the front speaker.
> > This commit enables the bass speaker on top of the aforementioned
> > work to improve the acoustic experience.
> >
> > Signed-off-by: Chris Chiu <chiu@endlessm.com>
> > Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> > ---
> >
> > Notes:
> > v2:
> > - Use existing alc285_fixup_speaker2_to_dac1 instead of new fixup function
> > - Correct the commit hash number in the commit message
> > - Remove the redundant fixup ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC
>
> Could you rebase on the latest for-linus branch? This patch isn't
> applied cleanly any longer.
>
>
> thanks,
>
> Takashi
Got it. I'll prepare a v3 to rebase on latest for-lnus.
Chris
prev parent reply other threads:[~2019-12-30 3:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 10:08 [PATCH v2] ALSA: hda/realtek - Enable the bass speaker of ASUS UX431FLC Chris Chiu
2019-12-28 8:05 ` Takashi Iwai
2019-12-30 3:12 ` Chris Chiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB4CAwd=DNOqsRDEB5tRtN7yUgkM6fXi3yy5-PzW=3cCx=_45A@mail.gmail.com' \
--to=chiu@endlessm.com \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=jian-hong@endlessm.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=tomas.espeleta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).