From: Marc Dionne <marc.dionne@auristor.com>
To: David Howells <dhowells@redhat.com>
Cc: Xin Long <lucien.xin@gmail.com>,
Vadim Fedorenko <vfedorenko@novek.ru>,
"David S. Miller" <davem@davemloft.net>,
linux-afs@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rxrpc: Enable IPv6 checksums on transport socket
Date: Fri, 29 Apr 2022 09:20:17 -0300 [thread overview]
Message-ID: <CAB9dFdtU05RgYwscCm-WX3ZNMiD0gbd2kTS61HvRHrPN=f25UA@mail.gmail.com> (raw)
In-Reply-To: <165109503652.611257.12851860419631266883.stgit@warthog.procyon.org.uk>
On Wed, Apr 27, 2022 at 6:30 PM David Howells <dhowells@redhat.com> wrote:
>
> AF_RXRPC doesn't currently enable IPv6 UDP Tx checksums on the transport
> socket it opens and the checksums in the packets it generates end up 0.
>
> It probably should also enable IPv6 UDP Rx checksums and IPv4 UDP
> checksums. The latter only seem to be applied if the socket family is
> AF_INET and don't seem to apply if it's AF_INET6. IPv4 packets from an
> IPv6 socket seem to have checksums anyway.
>
> What seems to have happened is that the inet_inv_convert_csum() call didn't
> get converted to the appropriate udp_port_cfg parameters - and
> udp_sock_create() disables checksums unless explicitly told not too.
>
> Fix this by enabling the three udp_port_cfg checksum options.
>
> Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
> Reported-by: Marc Dionne <marc.dionne@auristor.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Xin Long <lucien.xin@gmail.com>
> cc: Vadim Fedorenko <vfedorenko@novek.ru>
> cc: David S. Miller <davem@davemloft.net>
> cc: linux-afs@lists.infradead.org
> ---
>
> net/rxrpc/local_object.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c
> index a4111408ffd0..6a1611b0e303 100644
> --- a/net/rxrpc/local_object.c
> +++ b/net/rxrpc/local_object.c
> @@ -117,6 +117,7 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
> local, srx->transport_type, srx->transport.family);
>
> udp_conf.family = srx->transport.family;
> + udp_conf.use_udp_checksums = true;
> if (udp_conf.family == AF_INET) {
> udp_conf.local_ip = srx->transport.sin.sin_addr;
> udp_conf.local_udp_port = srx->transport.sin.sin_port;
> @@ -124,6 +125,8 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
> } else {
> udp_conf.local_ip6 = srx->transport.sin6.sin6_addr;
> udp_conf.local_udp_port = srx->transport.sin6.sin6_port;
> + udp_conf.use_udp6_tx_checksums = true;
> + udp_conf.use_udp6_rx_checksums = true;
> #endif
> }
> ret = udp_sock_create(net, &udp_conf, &local->socket);
Works for me, and I think we want all 3 settings, as a socket created
by a userspace application other than kafs may be a V4 socket.
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
Marc
prev parent reply other threads:[~2022-04-29 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 21:30 [PATCH] rxrpc: Enable IPv6 checksums on transport socket David Howells
2022-04-28 2:18 ` Xin Long
2022-04-29 12:20 ` Marc Dionne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB9dFdtU05RgYwscCm-WX3ZNMiD0gbd2kTS61HvRHrPN=f25UA@mail.gmail.com' \
--to=marc.dionne@auristor.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).