LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Marc Dionne <marc.c.dionne@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	x86@kernel.org
Subject: Re: x86/fpu: Don't export __kernel_fpu_{begin,end}()
Date: Wed, 9 Jan 2019 13:40:14 -0400
Message-ID: <CAB9dFdvRAzqnRAUEr3Y6H+h6viwdEMDpWP2Gf=tj3-0ojH58Xg@mail.gmail.com> (raw)
In-Reply-To: <20190109170935.e6b6rwzpk6dlruu4@linutronix.de>

On Wed, Jan 9, 2019 at 1:09 PM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> On 2019-01-09 17:52:35 [+0100], Greg Kroah-Hartman wrote:
> > If there are no in-kernel users, the symbols should not be exported
> > anymore.  That's nothing new, we have always done this.
>
> The thing is that we had
>   EXPORT_SYMBOL(__kernel_fpu_begin)
>   EXPORT_SYMBOL_GPL(kernel_fpu_begin)
>
> and now __kernel_fpu_begin() is no longer exported and static only.
> All in kernel user (including the kvm module) use kernel_fpu_begin()
> which is not available to proprietary modules. Hence Marc's mail.
>
> > > On the other hand could we just drop EXPORT_SYMBOL_GPL? I doubt this
> > > helps in any way yet please correct me if I am wrong.
> >
> > Yes, it helps, please leave it as-is.
>
> As you say. I only notice that certain things used to work and then no
> longer do because due to $rework it somehow become EXPORT_SYMBOL_GPL
> only and people complain and we tend to switch the export back to
> EXPORT_SYMBOL. I'm not aware of a case where it actually helped in
> anyway.
>
> > thanks,
> >
> > greg k-h
>
> Sebastian

I would point out that there are several precedents for restoring
exports after functionality has been unintentionally made GPL only;
from a quick lookup these are some examples:

  8af190958059 ("x86/paravirt: Remove GPL from pv_ops export")
  31c5bda3a656 ("mm: fix exports that inadvertently make put_page()
EXPORT_SYMBOL_GPL")
  1e5476815fd7 ("x86/tlb: Drop the _GPL from the cpu_tlbstate export")
  b562c171cf01 ("locking/refcounts: Do not force refcount_t usage as
GPL-only export")

Marc

  reply index

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <git-mailbomb-linux-master-12209993e98c5fa1855c467f22a24e3d5b8be205@kernel.org>
2019-01-07 22:08 ` Marc Dionne
2019-01-09 11:19   ` Sebastian Andrzej Siewior
2019-01-09 16:52     ` Greg Kroah-Hartman
2019-01-09 17:09       ` Sebastian Andrzej Siewior
2019-01-09 17:40         ` Marc Dionne [this message]
2019-01-10 13:13           ` Greg Kroah-Hartman
2019-01-10 13:11         ` Greg Kroah-Hartman
2019-01-10 17:32           ` Hutter, Tony
2019-01-10 18:07             ` Sebastian Andrzej Siewior
2019-01-10 18:24               ` Greg Kroah-Hartman
2019-01-11  3:18                 ` Kash Pande
2019-01-11  5:04                 ` Lukas Wunner
2019-01-11  5:40                   ` Greg Kroah-Hartman
2019-01-11 18:06                     ` Lukas Wunner
2019-01-23 15:58                     ` Pavel Machek
2019-01-15 13:01                 ` Rene Schickbauer
2019-01-15 13:32                   ` Christoph Hellwig
2019-01-15 13:42                   ` Greg Kroah-Hartman
2019-01-15 18:51                     ` Kash Pande
2019-01-21 12:30                     ` Stephan von Krawczynski
2019-01-15 18:26                 ` Kash Pande
2019-01-11  3:07 Kash Pande
     [not found] <20190111054058.GA27966 () kroah ! com>
2019-01-11  6:24 ` Kash Pande

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB9dFdvRAzqnRAUEr3Y6H+h6viwdEMDpWP2Gf=tj3-0ojH58Xg@mail.gmail.com' \
    --to=marc.c.dionne@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git