From: Sami Tolvanen <samitolvanen@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: remove duplicate dependencies from .mod files
Date: Tue, 18 Feb 2020 11:21:42 -0800 [thread overview]
Message-ID: <CABCJKudcVo95FcYGJ4223dqVEnkQnQJLx7fVaj1jF21n+sYEcg@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNARyYqmSByD3jQr+TPe1RHEj9CxqRE880AqxA5SU3yUk5A@mail.gmail.com>
Hi Masahiro,
On Sat, Feb 15, 2020 at 8:28 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> masahiro@grover:~/workspace/linux-kbuild$ llvm-nm
> drivers/gpu/drm/nouveau/nouveau.o | sed -n 's/^ *U //p' | sort -u |
> wc
> 572 572 11478
Thank you for testing this!
> Does ACK do this differently?
Yes, the difference is that we use LTO and after looking into this a
bit more, it turns out that when the individual files in the thin
archive are LLVM bitcode, llvm-nm behaves differently and prints out
the symbols for each file separately.
$ llvm-nm drivers/gpu/drm/nouveau/nouveau.o
...
nvif/client.o:
---------------- W __cfi_check
---------------- W __cfi_check_fail
U __cfi_slowpath_diag
U __ubsan_handle_cfi_check_fail
---------------- T nvif_client_fini
---------------- T nvif_client_init
---------------- T nvif_client_ioctl
---------------- T nvif_client_resume
---------------- T nvif_client_suspend
U nvif_object_fini
U nvif_object_init
U strncpy
nvif/device.o:
---------------- W __cfi_check
---------------- W __cfi_check_fail
U __ubsan_handle_cfi_check_fail
U kfree
---------------- T nvif_device_fini
---------------- T nvif_device_init
---------------- T nvif_device_time
U nvif_object_fini
U nvif_object_init
U nvif_object_mthd
U nvif_user_fini
...
While this output format still works for us, it does generate a lot of
duplicates. Anyway, I think we can come back to this when LTO is
closer to getting upstreamed.
Sami
prev parent reply other threads:[~2020-02-18 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 13:19 [PATCH] kbuild: remove duplicate dependencies from .mod files Sami Tolvanen
2020-02-12 13:22 ` Masahiro Yamada
2020-02-12 17:13 ` Sami Tolvanen
2020-02-16 4:27 ` Masahiro Yamada
2020-02-18 19:21 ` Sami Tolvanen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABCJKudcVo95FcYGJ4223dqVEnkQnQJLx7fVaj1jF21n+sYEcg@mail.gmail.com \
--to=samitolvanen@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).