From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED70AC33CAF for ; Thu, 16 Jan 2020 21:45:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3FF62072B for ; Thu, 16 Jan 2020 21:45:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tYITaZrs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387709AbgAPVpZ (ORCPT ); Thu, 16 Jan 2020 16:45:25 -0500 Received: from mail-ua1-f67.google.com ([209.85.222.67]:46986 "EHLO mail-ua1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729388AbgAPVpW (ORCPT ); Thu, 16 Jan 2020 16:45:22 -0500 Received: by mail-ua1-f67.google.com with SMTP id l6so8207927uap.13 for ; Thu, 16 Jan 2020 13:45:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tkSAt1Pw50rKdG/hn5morljVtZomrkNl/2z5xne6PRw=; b=tYITaZrsivqfC+GdC03l8Z8h3bZpMk/AxRJZ5m3Cq3lP1GhjDNlzuzFHH0Pn2+w9Bp 7hq+CoXS8VEDdhnMjKVZPNodzvjOUAaKuYJ/ddFf8vOlsJnqSle+AlNiaLEcRnwKSGTP 5gI69wlRAJP+9qKZcEhtfjYhon9km/BJzdEnZr70+1XtamA4m5kF7Ynuucv4V82zyCFO H2TlLCrfyCjDGPgKEI6sEsRnApccctQO8D2j+8EC7xolfZWg7J4pQivRrN9lRA6P8BUk bMbwCjGUJxwYv2NA596Hgs8T4QOpc3vlL/TpIEXN+OH+nuTnqjTX9Bzg6hCJI8tqaUMO EkDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tkSAt1Pw50rKdG/hn5morljVtZomrkNl/2z5xne6PRw=; b=jPj6usQmHp72WMRhQQlPUVBhmmGJXrxd58EBi4kmr+oMXd4sdd0qVNg3t+EmZCome0 9yCjzu/dC1pr9seK+P8K24nx1GM2MuixW2i9KsJtZJ41FAETbVOwAFHORVJ5M8Js9Mff EIsObNr1JysOJh4CkZOvDTIqE3o0kUnlJiPEd707C0M9DiHR0duf/vh9Rc0W4qTCtvFQ 5Lj8lSg2JJQZMrF/KxOUsio9AkfaKxvDmsL3XkRSV6HpPwcw7FaRNE83KOcLTwQsI55p uvgHVpQ1yn6gvZ+aeLQ0HIDzKclVapITQnIrLuRMPieEkW4TsB/ZvGdQUdu9H3ryu1S0 mfMg== X-Gm-Message-State: APjAAAVIUXWckDuiI0CU0C5Vw7aS8keR4Av0i5Qk3BRm+5hjkkY0C83a bSB9w8kluUjZBGjuRCxc+TTTqfJPafVtnXvheaz/kQ== X-Google-Smtp-Source: APXvYqx9xgh+f+ErpWs3BksSZ71jt7xPPMU4gWghLYUHcYc41EpoUSU/qL8aa7KJUXqJ40wX1Da/EhNZbQRobWoILhU= X-Received: by 2002:ab0:618a:: with SMTP id h10mr19510791uan.53.1579211120670; Thu, 16 Jan 2020 13:45:20 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191206221351.38241-1-samitolvanen@google.com> <20191206221351.38241-9-samitolvanen@google.com> <20200116173950.GB21396@willie-the-truck> In-Reply-To: <20200116173950.GB21396@willie-the-truck> From: Sami Tolvanen Date: Thu, 16 Jan 2020 13:45:09 -0800 Message-ID: Subject: Re: [PATCH v6 08/15] arm64: disable function graph tracing with SCS To: Will Deacon Cc: Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Mark Rutland , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 16, 2020 at 9:39 AM Will Deacon wrote: > > On Fri, Dec 06, 2019 at 02:13:44PM -0800, Sami Tolvanen wrote: > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index b1b4476ddb83..49e5f94ff4af 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -149,7 +149,7 @@ config ARM64 > > select HAVE_FTRACE_MCOUNT_RECORD > > select HAVE_FUNCTION_TRACER > > select HAVE_FUNCTION_ERROR_INJECTION > > - select HAVE_FUNCTION_GRAPH_TRACER > > + select HAVE_FUNCTION_GRAPH_TRACER if !SHADOW_CALL_STACK > > select HAVE_GCC_PLUGINS > > select HAVE_HW_BREAKPOINT if PERF_EVENTS > > select HAVE_IRQ_TIME_ACCOUNTING > > I think this is the wrong way around, as we support the graph tracer > today and so I think SHADOW_CALL_STACK should depend on !GRAPH_TRACER > and possibly even EXPERT until this is resolved. Sure, sounds reasonable. I'll change this in the next version. Sami