From: Sami Tolvanen <samitolvanen@google.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Dávid Bolvanský" <david.bolvansky@gmail.com>,
"Eli Friedman" <efriedma@quicinc.com>,
stable@vger.kernel.org, "Joe Perches" <joe@perches.com>,
"Tony Luck" <tony.luck@intel.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Daniel Axtens" <dja@axtens.net>,
"Arvind Sankar" <nivedita@alum.mit.edu>,
"Dan Williams" <dan.j.williams@intel.com>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Kees Cook" <keescook@chromium.org>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] lib/string.c: implement stpcpy
Date: Fri, 14 Aug 2020 17:53:28 -0700 [thread overview]
Message-ID: <CABCJKue4ikLs9NuxkhwxZUMZzgD10mVXnwt4=_8euXer8gzOQQ@mail.gmail.com> (raw)
In-Reply-To: <20200815002417.1512973-1-ndesaulniers@google.com>
Hi Nick,
On Fri, Aug 14, 2020 at 5:24 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> LLVM implemented a recent "libcall optimization" that lowers calls to
> `sprintf(dest, "%s", str)` where the return value is used to
> `stpcpy(dest, str) - dest`. This generally avoids the machinery involved
> in parsing format strings.
>
> `stpcpy` is just like `strcpy` except:
> 1. it returns the pointer to the new tail of `dest`. This allows you to
> chain multiple calls to `stpcpy` in one statement.
> 2. it requires the parameters not to overlap. Calling `sprintf` with
> overlapping arguments was clarified in ISO C99 and POSIX.1-2001 to be
> undefined behavior.
>
> `stpcpy` was first standardized in POSIX.1-2008.
>
> Implement this so that we don't observe linkage failures due to missing
> symbol definitions for `stpcpy`.
>
> Similar to last year's fire drill with:
> commit 5f074f3e192f ("lib/string.c: implement a basic bcmp")
>
> This optimization was introduced into clang-12.
>
> Cc: stable@vger.kernel.org
> Link: https://bugs.llvm.org/show_bug.cgi?id=47162
> Link: https://github.com/ClangBuiltLinux/linux/issues/1126
> Link: https://man7.org/linux/man-pages/man3/stpcpy.3.html
> Link: https://pubs.opengroup.org/onlinepubs/9699919799/functions/stpcpy.html
> Link: https://reviews.llvm.org/D85963
> Reported-by: Sami Tolvanen <samitolvanen@google.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> include/linux/string.h | 3 +++
> lib/string.c | 23 +++++++++++++++++++++++
> 2 files changed, 26 insertions(+)
Thank you for the patch! I can confirm that this fixes the build for
me with ToT Clang.
Tested-by: Sami Tolvanen <samitolvanen@google.com>
Sami
next prev parent reply other threads:[~2020-08-15 21:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 0:24 [PATCH] lib/string.c: implement stpcpy Nick Desaulniers
2020-08-15 0:52 ` Joe Perches
2020-08-15 2:00 ` Nick Desaulniers
2020-08-15 0:53 ` Sami Tolvanen [this message]
2020-08-15 1:33 ` Arvind Sankar
2020-08-15 1:40 ` Arvind Sankar
2020-08-15 2:09 ` [PATCH v2] " Nick Desaulniers
2020-08-15 2:58 ` Arvind Sankar
2020-08-15 3:42 ` Joe Perches
2020-08-15 16:34 ` Kees Cook
2020-08-15 17:38 ` Dávid Bolvanský
2020-08-15 20:47 ` Nick Desaulniers
2020-08-15 21:23 ` Joe Perches
2020-08-15 21:27 ` Dávid Bolvanský
2020-08-15 21:28 ` Nick Desaulniers
2020-08-15 21:31 ` Joe Perches
2020-08-15 22:17 ` Nick Desaulniers
2020-08-16 0:19 ` Fangrui Song
2020-08-16 5:22 ` Sedat Dilek
2020-08-16 15:02 ` Arvind Sankar
2020-08-17 17:14 ` Sami Tolvanen
2020-08-17 18:36 ` Nick Desaulniers
2020-08-17 19:15 ` Kees Cook
2020-08-17 20:13 ` Arvind Sankar
2020-08-17 21:45 ` Nick Desaulniers
[not found] ` <77557c29286140dea726cc334b4f59fc@AcuMS.aculab.com>
2020-08-18 8:32 ` Joe Perches
2020-08-17 19:16 ` Kees Cook
2020-08-15 2:00 ` [PATCH] " Nick Desaulniers
2020-08-15 22:17 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABCJKue4ikLs9NuxkhwxZUMZzgD10mVXnwt4=_8euXer8gzOQQ@mail.gmail.com' \
--to=samitolvanen@google.com \
--cc=akpm@linux-foundation.org \
--cc=alexandru.ardelean@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dan.j.williams@intel.com \
--cc=david.bolvansky@gmail.com \
--cc=dja@axtens.net \
--cc=efriedma@quicinc.com \
--cc=joe@perches.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).