From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B79C35257 for ; Mon, 21 Sep 2020 18:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3767220C09 for ; Mon, 21 Sep 2020 18:58:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VwM6SxPc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbgIUS6c (ORCPT ); Mon, 21 Sep 2020 14:58:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727014AbgIUS6c (ORCPT ); Mon, 21 Sep 2020 14:58:32 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE264C0613D0 for ; Mon, 21 Sep 2020 11:58:31 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id gr14so19337649ejb.1 for ; Mon, 21 Sep 2020 11:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rrEufNVuY5dCBzinzTyZLnRAK6NDit4k748EnZ9ZGyU=; b=VwM6SxPchzpHYvDq5MuGqptnfOCO+2u8UOZQsUHmvXP+yQTF+Z7wlraeVtjd/s9jlB wV193ZvJeoHSX0mG5NaEp1P+oe7FoNjVRmUSb2Z+JinKsMwFIqn+MpalsijQarctvj4U FH4y6mRhga1p9JKtJgLYS2O01gvN0JoRMzpIJ8sTPjHm+K3XvxLJoxyawOroxTt3ewXo 2erVwwtPxW6qCdmd6A02Wa5wSMbzwpQ/xA7DOELk4+u1Yv0Dw6Gb0gPjk1AInJx+Npb8 9g541oYiyMOVYQWN0p1s+dSK+qehJVoUb8ZcAzai39YkrQsAMRZIWHvBa3cE/5jkadoT Dtig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rrEufNVuY5dCBzinzTyZLnRAK6NDit4k748EnZ9ZGyU=; b=RyPcSTftBOqJ2iW+JmwbHnk9zRhgTKg4iINXf4SW3A9ZrTBjI/tm2XI3f7x2OEvSBQ e8Yi/zJD/bPqFoS5PLIQqbCl7vlH/9Kg+45Mu/KuuKHgkVQKC0TqnLv1k43ldu2xR4Iv GWm6B7aCZ7WjxWtSRFUllIMthBuzCccxMgIpJU8x1yo1jQvZl/O+sn/wPvkIbtPVUdsy iAYH6hw5lO6lX7u6qoJASM5j2t0TKIlNJTyALR/Htzko+eVge8lpPyhIVlkVgANgYCno QI2Bod42JSQlz6q+Km657pJGbeslCAaZNFEfD0r+eOrS+8yw4flcq/E7xlK8LaYB+b81 1ZXw== X-Gm-Message-State: AOAM531xFf5qNQZtl0ifiW7Rd9veq9jEwL1KdBguUBdvBP4rfewTBud0 W2PJGmkHaggdTbLfCpE3y8at8bgJ7K7rvoxWlsIwuw== X-Google-Smtp-Source: ABdhPJwAs9ksH6re9qMXbI2fsKP5Ghj4mOoCzkBFQS+BQszgLy1pqKFO8fFSdMFWe7XQ/UpW1tcdUlWla4BBqoqymc8= X-Received: by 2002:a17:906:ecf1:: with SMTP id qt17mr960026ejb.158.1600714709946; Mon, 21 Sep 2020 11:58:29 -0700 (PDT) MIME-Version: 1.0 References: <20200918201436.2932360-1-samitolvanen@google.com> <20200918201436.2932360-14-samitolvanen@google.com> <202009181427.86DE61B@keescook> In-Reply-To: <202009181427.86DE61B@keescook> From: Sami Tolvanen Date: Mon, 21 Sep 2020 11:58:19 -0700 Message-ID: Subject: Re: [PATCH v3 13/30] kbuild: lto: postpone objtool To: Kees Cook Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , linux-arm-kernel , linux-kbuild , LKML , linux-pci@vger.kernel.org, X86 ML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nick and 0-day bot both let me know that there's a typo in this patch, which I'll fix in v4: diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index f7daa59ff14f..00d7baaf7949 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -223,7 +223,7 @@ dtc_cpp_flags = -Wp,-MMD,$(depfile).pre.tmp -nostdinc \ objtool_args = \ $(if $(CONFIG_UNWINDER_ORC),orc generate,check) \ $(if $(part-of-module), --module,) \ - $(if $(CONFIG_FRAME_POINTER), --no-fp,) \ + $(if $(CONFIG_FRAME_POINTER),, --no-fp) \ $(if $(CONFIG_GCOV_KERNEL), --no-unreachable,) \ $(if $(CONFIG_RETPOLINE), --retpoline,) \ $(if $(CONFIG_X86_SMAP), --uaccess,) \ Sami On Fri, Sep 18, 2020 at 2:27 PM Kees Cook wrote: > > On Fri, Sep 18, 2020 at 01:14:19PM -0700, Sami Tolvanen wrote: > > With LTO, LLVM bitcode won't be compiled into native code until > > modpost_link, or modfinal for modules. This change postpones calls > > to objtool until after these steps, and moves objtool_args to > > Makefile.lib, so the arguments can be reused in Makefile.modfinal. > > > > Signed-off-by: Sami Tolvanen > > Thanks for reorganizing this! > > Reviewed-by: Kees Cook > > -- > Kees Cook > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202009181427.86DE61B%40keescook.