From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7675DC47404 for ; Mon, 7 Oct 2019 21:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 464B220867 for ; Mon, 7 Oct 2019 21:24:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jda3vWTj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729368AbfJGVYc (ORCPT ); Mon, 7 Oct 2019 17:24:32 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:35468 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728846AbfJGVYb (ORCPT ); Mon, 7 Oct 2019 17:24:31 -0400 Received: by mail-ua1-f68.google.com with SMTP id n63so4559409uan.2 for ; Mon, 07 Oct 2019 14:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qtdz6MVtYHywhBENAE676gRhNyUtv8gAoEkfWav5ZEE=; b=jda3vWTj0miv5Am77DVta9H3DhF8wa5FxKVgdI4uE3Hf3y5VolZNdaSZuMVFuSa8ND CCPsWw6RrkFA8ESPKSBAZTfBAIcrgIXPC/x2M830dN7PeJm3um62G+1lnr4CN2uDqd/y H01jkLXXB6MV8d3lkx6lhEYcl1WOMXIfZ9DPgu0ZQjGpsjeIhvZrx/VkFH0ZtdlkL7Ky vleIsngnbLNonANVIWsxTZr0YmPKOl5EciCZeoLHvehGpV8NkLn7Vk12Ox3bqdLHZJOe tNvFi+V0b0H9qkb3AesU7ku3TJxUpXizb3Cnx34xFg+AgVGURFUEaS6I55ROgfmWCA83 2iSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qtdz6MVtYHywhBENAE676gRhNyUtv8gAoEkfWav5ZEE=; b=EqilejyYVoG22/gp1dFd8moOQQaZOVG6FGixqz2OoxLFcJcAg6wCBsKalpmXqTOH6h dvisIgi9vvDLHtcSD7qeYlrU0WRhY+rAWGrhEQaGgDjRAyLZrZPTQaE6eU09i3WgZQGA mMYCeOaKChtO26Ei98bjn8/UQCzOXBQ0/rZMJq2F54vGq+Jp8XY9WhTKvi5X3PY22bbw 28RiZCZ4Y/L5I26tcNxNCniXjCL/CfEf0SVLDv1oHICT2OvGbYlOI+UaFXsvsTVQncYR sfLQ3qrkgj+i2EYo/go07EXBwDgCNd7s25QpiBoTyS1vogLw3bpG6U80CKkkzW2K/PPu 7vfg== X-Gm-Message-State: APjAAAXlo0C28g0GYqxmBBSxqP8An0eJBi9wqPtQMQJxnzFqb1dPLIEN bVpbwPg5LTi8FBF00vSf4tknjPs57VUIpYFUxz8wIQ== X-Google-Smtp-Source: APXvYqxpgwy0BoI9XN74BCjJ5c7Z7Gv6hOoSj196SzYRlfhhtl2bzG4e9xDKY8vt5g+W0Z3weotG80/1mMTbAVb2YBo= X-Received: by 2002:ab0:77cc:: with SMTP id y12mr4639713uar.110.1570483469932; Mon, 07 Oct 2019 14:24:29 -0700 (PDT) MIME-Version: 1.0 References: <20191007201452.208067-1-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Mon, 7 Oct 2019 14:24:18 -0700 Message-ID: Subject: Re: [PATCH] arm64: lse: fix LSE atomics with LLVM's integrated assembler To: Nick Desaulniers Cc: Catalin Marinas , Will Deacon , Andrew Murray , Kees Cook , Linux ARM , LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 7, 2019 at 1:28 PM 'Nick Desaulniers' via Clang Built Linux wrote: > I tried adding `.arch armv8-a+lse` directives to all of the inline asm: > https://github.com/ClangBuiltLinux/linux/issues/573#issuecomment-535098996 Yes, I had a similar patch earlier. I feel like using a command line parameter here is cleaner, but I'm fine with either solution. > One thing to be careful about is that blankets the entire kernel in > `+lse`, allowing LSE atomics to be selected at any point. Is that a problem? The current code allows LSE instructions with gcc in any file that includes , which turns out to be quite a few places. Sami