linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Dario Pagani <dario.pagani.146@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: thrustmaster: clean up Makefile and adapt quirks
Date: Tue, 10 Aug 2021 22:21:52 +0300	[thread overview]
Message-ID: <CABD-7My1Nc=TEY=qwQo=G-XA718zRDetYF7KchQRVeTwPg60uA@mail.gmail.com> (raw)
In-Reply-To: <20210810102148.9764-1-lukas.bulwahn@gmail.com>

Works on my VM.

Kim

ti 10. elok. 2021 klo 13.21 Lukas Bulwahn (lukas.bulwahn@gmail.com) kirjoitti:
>
> Commit c49c33637802 ("HID: support for initialization of some Thrustmaster
> wheels") messed up the Makefile and quirks during the refactoring of this
> commit.
>
> Luckily, ./scripts/checkkconfigsymbols.py warns on non-existing configs:
>
> HID_TMINIT
> Referencing files: drivers/hid/Makefile, drivers/hid/hid-quirks.c
>
> Following the discussion (see Link), CONFIG_HID_THRUSTMASTER is the
> intended config for CONFIG_HID_TMINIT and the file hid-tminit.c was
> actually added as hid-thrustmaster.c.
>
> So, clean up Makefile and adapt quirks to that refactoring.
>
> Fixes: c49c33637802 ("HID: support for initialization of some Thrustmaster wheels")
> Link: https://lore.kernel.org/linux-input/CAKXUXMx6dByO03f3dX0X5zjvQp0j2AhJBg0vQFDmhZUhtKxRxw@mail.gmail.com/
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Dario, Kim, please review, test and ack.
> Jiri, Benjamin, please pick this quick fix-up patch.
>
>  drivers/hid/Makefile     | 1 -
>  drivers/hid/hid-quirks.c | 2 --
>  2 files changed, 3 deletions(-)
>
> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> index 1ea1a7c0b20f..e29efcb1c040 100644
> --- a/drivers/hid/Makefile
> +++ b/drivers/hid/Makefile
> @@ -115,7 +115,6 @@ obj-$(CONFIG_HID_STEELSERIES)       += hid-steelseries.o
>  obj-$(CONFIG_HID_SUNPLUS)      += hid-sunplus.o
>  obj-$(CONFIG_HID_GREENASIA)    += hid-gaff.o
>  obj-$(CONFIG_HID_THRUSTMASTER) += hid-tmff.o hid-thrustmaster.o
> -obj-$(CONFIG_HID_TMINIT)       += hid-tminit.o
>  obj-$(CONFIG_HID_TIVO)         += hid-tivo.o
>  obj-$(CONFIG_HID_TOPSEED)      += hid-topseed.o
>  obj-$(CONFIG_HID_TWINHAN)      += hid-twinhan.o
> diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> index 51b39bda9a9d..2e104682c22b 100644
> --- a/drivers/hid/hid-quirks.c
> +++ b/drivers/hid/hid-quirks.c
> @@ -662,8 +662,6 @@ static const struct hid_device_id hid_have_special_driver[] = {
>         { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb653) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65a) },
> -#endif
> -#if IS_ENABLED(CONFIG_HID_TMINIT)
>         { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65d) },
>  #endif
>  #if IS_ENABLED(CONFIG_HID_TIVO)
> --
> 2.17.1
>

  reply	other threads:[~2021-08-10 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 10:21 [PATCH] HID: thrustmaster: clean up Makefile and adapt quirks Lukas Bulwahn
2021-08-10 19:21 ` Kim Kuparinen [this message]
2021-08-20 12:54 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABD-7My1Nc=TEY=qwQo=G-XA718zRDetYF7KchQRVeTwPg60uA@mail.gmail.com' \
    --to=kimi.h.kuparinen@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dario.pagani.146@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).