From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Utkarsh Verma <utkarshverma294@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Joe Perches <joe@perches.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Documentation: checkpatch: Add SYMBOLIC_PERMS message
Date: Wed, 15 Sep 2021 03:58:54 +0530 [thread overview]
Message-ID: <CABJPP5DjazfiTUe3wvnKyk86hN+SUK7aP9K5GP0L5tRW_TD_xw@mail.gmail.com> (raw)
In-Reply-To: <87ee9qdft1.fsf@meer.lwn.net>
On Wed, Sep 15, 2021 at 2:40 AM Jonathan Corbet <corbet@lwn.net> wrote:
>
> Dwaipayan Ray <dwaipayanray1@gmail.com> writes:
>
> > On Sat, Sep 4, 2021 at 1:53 PM Utkarsh Verma <utkarshverma294@gmail.com> wrote:
> >>
> >> Add a new message type SYMBOLIC_PERMS under the 'Permissions'
> >> subsection. Octal permission bits are easier to read and understand
> >> instead of their symbolic macro names.
> >>
> >> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> >> Signed-off-by: Utkarsh Verma <utkarshverma294@gmail.com>
> >> Acked-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> >> Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> >> ---
> >> Documentation/dev-tools/checkpatch.rst | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
> >> index f0956e9ea2d8..41037594ec24 100644
> >> --- a/Documentation/dev-tools/checkpatch.rst
> >> +++ b/Documentation/dev-tools/checkpatch.rst
> >> @@ -957,6 +957,17 @@ Permissions
> >> Permission bits should use 4 digit octal permissions (like 0700 or 0444).
> >> Avoid using any other base like decimal.
> >>
> >> + **SYMBOLIC_PERMS**
> >> + Permission bits in the octal form are more readable and easier to
> >> + understand than their symbolic counterparts because many command-line
> >> + tools use this notation only. Experienced kernel developers have been using
> >
> > Let's remove "only".
> >
> >> + this traditional Unix permission bits for decades and so they find it
> >
> > Maybe you meant "these" here.
> >
> > With these changes made,
> > Acked-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
>
> I took the liberty of apply the patch with those changes made.
>
Thanks Jonathan.
Utkarsh, you can start working on your next patches after submitting, you don't
have to wait for the existing patches to be first accepted. They will follow
the same review -> changes -> review cycle until they are good for
acceptance.
Like lukas said, try preparing a batch of say 3 to 5 rules and let's
review it and get it in.
Thanks,
Dwaipayan.
prev parent reply other threads:[~2021-09-14 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 7:29 [PATCH] Documentation: checkpatch: Add SYMBOLIC_PERMS message Utkarsh Verma
2021-09-04 7:46 ` Lukas Bulwahn
2021-09-04 8:23 ` [PATCH v2] " Utkarsh Verma
2021-09-09 17:02 ` Dwaipayan Ray
2021-09-14 21:10 ` Jonathan Corbet
2021-09-14 22:28 ` Dwaipayan Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABJPP5DjazfiTUe3wvnKyk86hN+SUK7aP9K5GP0L5tRW_TD_xw@mail.gmail.com \
--to=dwaipayanray1@gmail.com \
--cc=corbet@lwn.net \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=utkarshverma294@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).