From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
To: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
git@xilinx.com, saikrishna12468@gmail.com
Subject: Re: [PATCH v3 1/3] firmware: xilinx: Add pinctrl support
Date: Sun, 28 Feb 2021 09:17:56 +0900 [thread overview]
Message-ID: <CABMQnVJ+hQ_sdXMdLzhv2Y65QW8Vi01VAjV=SCeOei-zOZ5dwQ@mail.gmail.com> (raw)
In-Reply-To: <1613131643-60062-2-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com>
Hi,
2021年2月12日(金) 21:10 Sai Krishna Potthuri
<lakshmi.sai.krishna.potthuri@xilinx.com>:
>
> Adding pinctrl support to query platform specific information (pins)
> from firmware.
>
> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
> drivers/firmware/xilinx/zynqmp.c | 114 +++++++++++++++++++++++++++
> include/linux/firmware/xlnx-zynqmp.h | 90 +++++++++++++++++++++
> 2 files changed, 204 insertions(+)
>
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index efb8a66efc68..299c3d5a9ebd 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -784,6 +784,120 @@ int zynqmp_pm_fpga_get_status(u32 *value)
> }
> EXPORT_SYMBOL_GPL(zynqmp_pm_fpga_get_status);
>
<snip>
> @@ -125,6 +131,12 @@ enum pm_query_id {
> PM_QID_CLOCK_GET_FIXEDFACTOR_PARAMS,
> PM_QID_CLOCK_GET_PARENTS,
> PM_QID_CLOCK_GET_ATTRIBUTES,
> + PM_QID_PINCTRL_GET_NUM_PINS = 6,
> + PM_QID_PINCTRL_GET_NUM_FUNCTIONS = 7,
> + PM_QID_PINCTRL_GET_NUM_FUNCTION_GROUPS = 8,
> + PM_QID_PINCTRL_GET_FUNCTION_NAME = 9,
> + PM_QID_PINCTRL_GET_FUNCTION_GROUPS = 10,
> + PM_QID_PINCTRL_GET_PIN_GROUPS = 11,
These do not have to have values, Because PM_QID_INVALID is 0.
> PM_QID_CLOCK_GET_NUM_CLOCKS = 12,
And you can drop value from this.
> PM_QID_CLOCK_GET_MAX_DIVISOR,
> };
> @@ -288,6 +300,44 @@ enum dll_reset_type {
> PM_DLL_RESET_PULSE,
> };
>
> +enum pm_pinctrl_config_param {
> + PM_PINCTRL_CONFIG_SLEW_RATE = 0,
> + PM_PINCTRL_CONFIG_BIAS_STATUS = 1,
> + PM_PINCTRL_CONFIG_PULL_CTRL = 2,
> + PM_PINCTRL_CONFIG_SCHMITT_CMOS = 3,
> + PM_PINCTRL_CONFIG_DRIVE_STRENGTH = 4,
> + PM_PINCTRL_CONFIG_VOLTAGE_STATUS = 5,
> + PM_PINCTRL_CONFIG_TRI_STATE = 6,
> + PM_PINCTRL_CONFIG_MAX = 7,
> +};
Same as above.
> +
> +enum pm_pinctrl_slew_rate {
> + PM_PINCTRL_SLEW_RATE_FAST = 0,
> + PM_PINCTRL_SLEW_RATE_SLOW = 1,
> +};
Same as above. Others are also specified.
> +
> +enum pm_pinctrl_bias_status {
> + PM_PINCTRL_BIAS_DISABLE = 0,
> + PM_PINCTRL_BIAS_ENABLE = 1,
> +};
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
next prev parent reply other threads:[~2021-02-28 0:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 12:07 [PATCH v3 0/3] Add ZynqMP pinctrl driver Sai Krishna Potthuri
2021-02-12 12:07 ` [PATCH v3 1/3] firmware: xilinx: Add pinctrl support Sai Krishna Potthuri
2021-02-28 0:17 ` Nobuhiro Iwamatsu [this message]
2021-03-01 7:07 ` Michal Simek
2021-03-02 8:09 ` Nobuhiro Iwamatsu
2021-02-12 12:07 ` [PATCH v3 2/3] dt-bindings: pinctrl: Add binding for ZynqMP pinctrl driver Sai Krishna Potthuri
2021-03-05 20:20 ` Rob Herring
2021-02-12 12:07 ` [PATCH v3 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Sai Krishna Potthuri
2021-02-28 0:48 ` Nobuhiro Iwamatsu
2021-03-01 13:03 ` Sai Krishna Potthuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABMQnVJ+hQ_sdXMdLzhv2Y65QW8Vi01VAjV=SCeOei-zOZ5dwQ@mail.gmail.com' \
--to=iwamatsu@nigauri.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=saikrishna12468@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).