linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: Nadim almas <nadim.902@gmail.com>
Cc: labbott@redhat.com, devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: android: ion: ion.c: Compression of lines for
Date: Mon, 1 Aug 2016 06:19:43 +0300	[thread overview]
Message-ID: <CABNMmsD_V3ZNzWeJr6pVQ+Q=huR63Mw-dpsJEsMLkujBsgjrSw@mail.gmail.com> (raw)
In-Reply-To: <1469979889-14816-1-git-send-email-nadim.902@gmail.com>

On Sun, Jul 31, 2016 at 6:44 PM, Nadim almas <nadim.902@gmail.com> wrote:
> This patch compresses two lines in to a single line in file
> ion.c
> if immediate return statement is found.It also removes variable
> ret as it is no longer needed.
>
> ne using script Coccinelle. And coccinelle uses following semantic
> patch for this compression function:
>
> @@
> expression e, ret;
> @@
>
> -ret =
> +return
>      e;
> -return ret;
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/android/ion/ion.c          | 8 +++-----
>
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 52345df..271395b 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -391,9 +391,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle)
>  {
> -       int ret;
>
> -       ret = kref_put(&handle->ref, ion_handle_destroy);
> -
> -       return ret;
> +       return kref_put(&handle->ref, ion_handle_destroy);
>  }
>
>  static int ion_handle_put(struct ion_handle *handle)
> @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
>                 return -ENODEV;
>         }
>         mutex_unlock(&client->lock);
> -       ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len);
> -       return ret;
> +       return buffer->heap->ops->phys(buffer->heap, buffer, addr, len);
>  }

Try to actually compile before sending your patch.

  reply	other threads:[~2016-08-01  3:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-31 15:44 [PATCH] Staging: android: ion: ion.c: Compression of lines for Nadim almas
2016-08-01  3:19 ` Giedrius Statkevičius [this message]
2016-08-02 18:13 Nadim almas
2016-08-14 12:52 ` Vaishali Thakkar
2016-08-15 14:48 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABNMmsD_V3ZNzWeJr6pVQ+Q=huR63Mw-dpsJEsMLkujBsgjrSw@mail.gmail.com' \
    --to=giedrius.statkevicius@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadim.902@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).