From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751821AbcGPQZg (ORCPT <rfc822;w@1wt.eu>);
	Sat, 16 Jul 2016 12:25:36 -0400
Received: from mail-wm0-f52.google.com ([74.125.82.52]:38370 "EHLO
	mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751629AbcGPQZf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 16 Jul 2016 12:25:35 -0400
MIME-Version: 1.0
In-Reply-To: <20160715222721.GF8740@kernel.org>
References: <20160715210836.GB19522@mwanda> <20160715222721.GF8740@kernel.org>
From: Stephane Eranian <eranian@google.com>
Date: Sat, 16 Jul 2016 09:25:32 -0700
Message-ID: <CABPqkBQL0QNtZF6vY_08bomxdFu=0e7CS9mqhCiVN_Y5Hi9GPQ@mail.gmail.com>
Subject: Re: [patch 2/2] perf jit: remove some no-op error handling
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 15, 2016 at 3:27 PM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> Em Sat, Jul 16, 2016 at 12:08:36AM +0300, Dan Carpenter escreveu:
>> info.e_machine is a uint16_t so m is never less than zero.  It looks
>> like this was maybe left over code from earlier versions so I've just
>> removed it.
>
> Yeah, it sure looks like that, applying, thanks,
>
Thanks for cleaning this up.

> - Arnaldo
>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
>> index 91bf333..55daeff 100644
>> --- a/tools/perf/jvmti/jvmti_agent.c
>> +++ b/tools/perf/jvmti/jvmti_agent.c
>> @@ -59,7 +59,6 @@ static int get_e_machine(struct jitheader *hdr)
>>       ssize_t sret;
>>       char id[16];
>>       int fd, ret = -1;
>> -     int m = -1;
>>       struct {
>>               uint16_t e_type;
>>               uint16_t e_machine;
>> @@ -81,11 +80,7 @@ static int get_e_machine(struct jitheader *hdr)
>>       if (sret != sizeof(info))
>>               goto error;
>>
>> -     m = info.e_machine;
>> -     if (m < 0)
>> -             m = 0; /* ELF EM_NONE */
>> -
>> -     hdr->elf_mach = m;
>> +     hdr->elf_mach = info.e_machine;
>>       ret = 0;
>>  error:
>>       close(fd);