From: Stephane Eranian <eranian@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Liang, Kan" <kan.liang@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] perf: Add munmap callback
Date: Wed, 24 Oct 2018 17:44:09 -0700 [thread overview]
Message-ID: <CABPqkBQYbQV86dWCHMZX0sMspkHXSpYOB6G+c2kSOf3d4R7dNQ@mail.gmail.com> (raw)
In-Reply-To: <20181025003444.GV3109@worktop.c.hoisthospitality.com>
On Wed, Oct 24, 2018 at 5:34 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Wed, Oct 24, 2018 at 05:25:59PM -0700, Stephane Eranian wrote:
> > On Wed, Oct 24, 2018 at 5:23 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > That is actually a different problem. And you're right, we never did fix
> > > that.
> > >
> > it is a different problem but the solution is the same: PERF_RECORD_UNMAP!
>
> But he's not actually doing PERF_RECORD_UNMAP, nor is his perf_munmap()
> hook sufficient to actually generate those.
>
You're right. But I saw that and thought, this is going in the right
direction: tracking munmap.
I agree with you that we should use this opportunity to track unmap
for his purpose but also
the issue I raised, which needs a new record type based on the new unmap hook.
> Now I agree that if he's going to do an munmap hook, he should do it
> 'right' and at the very least allow for PERF_RECORD_UNMAP to be done,
> but ideally simply pick up and finish that patch we had back then.
Agreed.
next prev parent reply other threads:[~2018-10-25 0:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 15:11 [PATCH 1/2] perf: Add munmap callback kan.liang
2018-10-24 15:11 ` [PATCH 2/2] perf/x86/intel: Fix missing physical address in large PEBS kan.liang
2018-10-24 16:23 ` [PATCH 1/2] perf: Add munmap callback Andi Kleen
2018-10-24 16:32 ` Arnaldo Carvalho de Melo
2018-10-24 18:12 ` Liang, Kan
2018-10-24 18:28 ` Andi Kleen
2018-10-25 0:31 ` Peter Zijlstra
2018-10-24 19:15 ` Arnaldo Carvalho de Melo
2018-10-24 19:30 ` Stephane Eranian
2018-10-25 0:23 ` Peter Zijlstra
2018-10-25 0:25 ` Stephane Eranian
2018-10-25 0:34 ` Peter Zijlstra
2018-10-25 0:44 ` Stephane Eranian [this message]
2018-11-01 14:09 ` Liang, Kan
2018-11-05 10:59 ` Stephane Eranian
2018-11-05 15:43 ` Liang, Kan
2018-11-06 15:00 ` Stephane Eranian
2018-11-06 16:47 ` Liang, Kan
2018-10-25 0:29 ` Peter Zijlstra
2018-10-25 14:00 ` Liang, Kan
2018-10-30 12:51 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPqkBQYbQV86dWCHMZX0sMspkHXSpYOB6G+c2kSOf3d4R7dNQ@mail.gmail.com \
--to=eranian@google.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).