Re: [PATCH 11/13] perf: add code to support PERF_SAMPLE_BRANCH_STACK (v3)

[Stephane Eranian <eranian@google.com>]

On Tue, Jan 10, 2012 at 2:25 AM, Arun Sharma <asharma@fb.com> wrote:
> On 1/9/12 8:49 AM, Stephane Eranian wrote:
>>
>> From: Roberto Agostino Vitillo<ravitillo@lbl.gov>
>>
>> This patch adds:
>> - ability to parse samples with PERF_SAMPLE_BRANCH_STACK
>> - sort on branches
>> - build histograms on branches
>>
> [..]
>>
>>  static struct sort_dimension sort_dimensions[] = {
>> -       { .name = "pid",        .entry =&sort_thread,   },
>> -       { .name = "comm",       .entry =&sort_comm,     },
>> -       { .name = "dso",        .entry =&sort_dso,      },
>> -       { .name = "symbol",     .entry =&sort_sym,      },
>> -       { .name = "parent",     .entry =&sort_parent,   },
>> -       { .name = "cpu",        .entry =&sort_cpu,      },
>> +       { .name = "pid",        .entry =&sort_thread,                   },
>> +       { .name = "comm",       .entry =&sort_comm,                     },
>> +       { .name = "dso",        .entry =&sort_dso,                      },
>> +       { .name = "dso_from",   .entry =&sort_dso_from,.taken = true    },
>> +       { .name = "dso_to",     .entry =&sort_dso_to,   .taken = true   },
>> +       { .name = "symbol",     .entry =&sort_sym,                      },
>> +       { .name = "symbol_from",.entry =&sort_sym_from,.taken = true    },
>> +       { .name = "symbol_to",  .entry =&sort_sym_to,   .taken = true   },
>> +       { .name = "parent",     .entry =&sort_parent,                   },
>> +       { .name = "cpu",        .entry =&sort_cpu,                      },
>>
>> +       { .name = "mispredict", .entry =&sort_mispredict, },
>>  };
>
>
> The new sort dimensions don't seem to show up in perf report -h. Could you
> please update the help text?
>
Can do this with the understanding that those are only avail when you
use branch sampling.

> Also:
>
> # perf script -h
>
>    -f, --fields <str>    comma separated output fields prepend with 'type:'.
> Valid types: hw,sw,trace,raw. Fields:
> comm,tid,pid,time,cpu,event,trace,ip,sym,dso,addr
>
> You probably want to add a field here, so I could:
>
> perf record -b any_call,u -e cycles:u
> perf script -f event,branch_stack
>
> and examine raw (symbolized) samples like I can with
>
> perf record -g
> perf script -f event,ip,sym
>
Ok, I'll look into this. Looks like a useful command for automating processing.

>  -Arun
>