From: Stephane Eranian <eranian@google.com>
To: David Ahern <dsahern@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"ak@linux.intel.com" <ak@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Rose Belcher <cel@us.ibm.com>,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Sonny Rao <sonnyrao@chromium.org>,
John Mccutchan <johnmccutchan@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH v6 1/4] perf,record: Add clockid parameter
Date: Mon, 30 Mar 2015 15:27:26 -0700 [thread overview]
Message-ID: <CABPqkBRgZJ0xit4--Q736e6dGvzgHpqaD6-LLAtyZfG+D_UEXQ@mail.gmail.com> (raw)
In-Reply-To: <5519CD1F.1000300@gmail.com>
On Mon, Mar 30, 2015 at 3:24 PM, David Ahern <dsahern@gmail.com> wrote:
> On 3/30/15 4:19 PM, Stephane Eranian wrote:
>>
>> @@ -761,6 +762,12 @@ void perf_evsel__config(struct perf_evsel *evsel,
>> struct record_opts *opts)
>> attr->disabled = 0;
>> attr->enable_on_exec = 0;
>> }
>> +
>> + if (opts->clockid >= 0) {
>> + attr->use_clockid = 1;
>> + attr->clockid = opts->clockid;
>> + } else
>> + attr->clockid = -1;
>> }
>
>
> The else part needs to be removed (can't set clockid to -1). And then ...
>
>> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
>> index fb43215..164441a 100644
>> --- a/tools/perf/util/header.c
>> +++ b/tools/perf/util/header.c
>> @@ -1098,6 +1098,8 @@ static void print_event_desc(struct perf_header *ph,
>> int fd, FILE *fp)
>> }
>> fprintf(fp, " }");
>> }
>> + fprintf(fp, ", clockid = %d", evsel->attr.clockid);
>> +
>
>
> this should be prefaced with:
>
> if (evsel->attr.use_clockid)
>
> (use_clockid bit says whether the clockid value was set)
Ok, will fix in V7 or Arnaldo grabs the patch and merges it.
next prev parent reply other threads:[~2015-03-30 22:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 22:19 [PATCH v6 0/4] perf: add support for profiling jitted code Stephane Eranian
2015-03-30 22:19 ` [PATCH v6 1/4] perf,record: Add clockid parameter Stephane Eranian
2015-03-30 22:24 ` David Ahern
2015-03-30 22:27 ` Stephane Eranian [this message]
2015-03-31 7:16 ` Peter Zijlstra
2015-03-31 7:28 ` Peter Zijlstra
2015-03-30 22:19 ` [PATCH v6 2/4] perf tools: add Java demangling support Stephane Eranian
2015-03-31 7:00 ` Pekka Enberg
2015-03-30 22:19 ` [PATCH v6 3/4] perf inject: add jitdump mmap injection support Stephane Eranian
2015-04-01 6:58 ` Adrian Hunter
[not found] ` <CABPqkBRd9+Ystsb-6gOn0Pni37BOc4uTGkj7DHfKbBvBCU9E7A@mail.gmail.com>
2015-04-08 12:15 ` Adrian Hunter
2015-04-08 14:12 ` Stephane Eranian
2015-04-10 12:51 ` Adrian Hunter
2015-04-13 0:37 ` Stephane Eranian
2015-04-13 7:03 ` Adrian Hunter
2015-03-30 22:19 ` [PATCH v6 4/4] perf tools: add JVMTI agent library Stephane Eranian
2015-03-31 7:33 ` [PATCH v6 0/4] perf: add support for profiling jitted code Brendan Gregg
2015-03-31 21:31 ` Brendan Gregg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPqkBRgZJ0xit4--Q736e6dGvzgHpqaD6-LLAtyZfG+D_UEXQ@mail.gmail.com \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=cel@us.ibm.com \
--cc=dsahern@gmail.com \
--cc=johnmccutchan@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=pawel.moll@arm.com \
--cc=peterz@infradead.org \
--cc=sonnyrao@chromium.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).