From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757212AbaDWOk0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Apr 2014 10:40:26 -0400
Received: from mail-oa0-f52.google.com ([209.85.219.52]:45334 "EHLO
	mail-oa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757161AbaDWOkW convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Apr 2014 10:40:22 -0400
MIME-Version: 1.0
In-Reply-To: <1398263914.1696.7.camel@leonhard>
References: <1398235235-4239-1-git-send-email-namhyung@kernel.org>
	<CABPqkBSgRmtnoGzb2KfLKK4QNkhUVzceU81x+o+PTLwNL3uL+A@mail.gmail.com>
	<1398263914.1696.7.camel@leonhard>
Date: Wed, 23 Apr 2014 16:40:21 +0200
Message-ID: <CABPqkBS+7Khz=8Z5gb_veQVoovjPwNmUjqnQta=cRuHrcQmy9A@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] perf record: Propagate exit status of a command
 line workload
From: Stephane Eranian <eranian@google.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 23, 2014 at 4:38 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> Hi Stephane,
>
> 2014-04-23 (수), 14:11 +0200, Stephane Eranian:
>> On Wed, Apr 23, 2014 at 8:40 AM, Namhyung Kim <namhyung@kernel.org> wrote:
>> > +out_child:
>> > +       if (forks) {
>> > +               int exit_status;
>> >
>> > -       return 0;
>> > +               if (!child_finished)
>> > +                       kill(rec->evlist->workload.pid, SIGTERM);
>> > +
>> > +               wait(&exit_status);
>> > +
>> > +               if (err < 0)
>> Not quite this. Although this works with my test case with 'false'.
>> It fails when I tried the opposite test case:
>>
>> $ perf record true && echo yes || echo no
>>   [ perf record: Woken up 1 times to write data ]
>>   [ perf record: Captured and wrote 0.013 MB perf.data (~589 samples) ]
>>   no
>>
>> The return code in this case is 255. I tracked it down to err being last set
>> by poll() which got interrupted by SIGCHLD. So I think the err value must
>> be overridden somehow in this case. Maybe something like:
>>
>>                         err = poll(evsel_list->pollfd, evsel_list->nr_fds, -1);
>>                         if (err < 0 &&  errno == EINTR && forks && done)
>>                                 err = 0;
>
> Hmm.. just checking "err < 0 && errno == EINTR" isn't enough?
>
> And I guess the same problem can be occurred during record__mmap_read()
> as it calls record__write() which eventually calls ion() and it seems
> not to handle the above case..  I'll cook a patch for it too.
>
That's true.
Now, do we care about the return value of poll()?

> Thanks,
> Namhyung
>
>
>