From: Stephane Eranian <eranian@google.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@gmail.com>,
a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org,
cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
andi@firstfloor.org, drepper@gmail.com
Subject: Re: [PATCHv3 0/3] perf tool: Add new event group management
Date: Fri, 6 Jul 2012 03:06:41 +0200 [thread overview]
Message-ID: <CABPqkBSS82X2Dt46jwLzbvC4WxkbewA8DhrMYjGmpAtugV2HNQ@mail.gmail.com> (raw)
In-Reply-To: <20120705164447.GE7533@infradead.org>
On Thu, Jul 5, 2012 at 6:44 PM, Arnaldo Carvalho de Melo
<acme@redhat.com> wrote:
> Em Thu, Jul 05, 2012 at 06:15:20PM +0200, Stephane Eranian escreveu:
>> On Mon, Jul 2, 2012 at 3:33 PM, Jiri Olsa <jolsa@redhat.com> wrote:
>> > perf, tool: Enable sampling on specified event group leader
>> >
>> > Adding the functionality to the group modifier event syntax.
>> > Allowing user to select leader event inside the group using
>> > event index (command line event position in the group).
>> >
>> > Following example selects e2 as leader:
>> > -e '{e1,e2,e3,e4}:2'
>> >
>> I don't understand why you actually need the :2 suffix. There can
>> only be one leader. So assume it is the first one. Users have to
>> know the first one is the leader which seems like a natural thing
>> to do for me. It would make you syntax less ugly than it already
>> is.
>
> Agreed, looks like creeping featurism.
>
>> I would have thought you could enable this with a simple
>> cmdline option which changes the way you interpret the
>> multiple -e options:
>>
>> perf record --group-reads -e e1,e2,e3 -e e4,e5,e6 .....
>>
>> Would setup the group leaders (e1, e4) for 2 groups.
>> NO curly braces, no : needed.
>
> Yeah, curly braces needed just when one wants to add group wide
> modifiers.
And even, in that case that seems overkill too.
You can simply repeat the modifier on each event. A group cannot
big that big. It is limited in size by the number of physical counters
plus the events constraints.
next prev parent reply other threads:[~2012-07-06 1:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 9:08 [PATCHv3 0/3] perf tool: Add new event group management Jiri Olsa
2012-06-29 9:08 ` [PATCH 1/3] perf, tool: Add support to parse event group syntax Jiri Olsa
2012-06-29 9:08 ` [PATCH 2/3] perf, tool: Enable grouping logic for parsed events Jiri Olsa
2012-06-29 16:47 ` Arnaldo Carvalho de Melo
2012-06-29 16:53 ` Jiri Olsa
2012-07-02 2:13 ` Namhyung Kim
2012-07-02 10:10 ` Jiri Olsa
2012-07-03 0:58 ` Namhyung Kim
2012-07-04 17:34 ` Jiri Olsa
2012-07-05 0:45 ` Namhyung Kim
2012-07-05 16:05 ` Peter Zijlstra
2012-07-05 16:43 ` Arnaldo Carvalho de Melo
2012-06-29 9:08 ` [PATCH 3/3] perf, test: Add automated tests for event group parsing Jiri Olsa
2012-07-02 1:53 ` [PATCHv3 0/3] perf tool: Add new event group management Namhyung Kim
2012-07-02 10:15 ` Jiri Olsa
2012-07-02 13:11 ` Namhyung Kim
2012-07-02 13:33 ` Jiri Olsa
2012-07-02 14:20 ` Namhyung Kim
2012-07-03 0:50 ` Namhyung Kim
2012-07-03 1:04 ` Arnaldo Carvalho de Melo
2012-07-05 16:15 ` Stephane Eranian
2012-07-05 16:44 ` Arnaldo Carvalho de Melo
2012-07-06 1:06 ` Stephane Eranian [this message]
2012-07-06 1:32 ` Ulrich Drepper
2012-07-06 1:42 ` Stephane Eranian
2012-07-09 11:05 ` Jiri Olsa
2012-07-09 11:15 ` Peter Zijlstra
2012-07-17 7:15 ` Stephane Eranian
2012-07-17 15:47 ` Andi Kleen
2012-07-18 10:21 ` Jiri Olsa
2012-07-18 12:34 ` Ulrich Drepper
2012-07-18 20:06 ` Jiri Olsa
2012-07-05 16:09 ` Stephane Eranian
2012-07-02 2:25 ` David Ahern
2012-07-02 10:07 ` Jiri Olsa
2012-07-02 10:19 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPqkBSS82X2Dt46jwLzbvC4WxkbewA8DhrMYjGmpAtugV2HNQ@mail.gmail.com \
--to=eranian@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=drepper@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).