From: Stephane Eranian <eranian@google.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf/core: restore mmap record type correctly
Date: Thu, 7 Mar 2019 11:28:26 -0800 [thread overview]
Message-ID: <CABPqkBTXAfYr4XkeFfUWBg9ygW2abWxmH79y9E-DbqLofS+mjw@mail.gmail.com> (raw)
In-Reply-To: <20190307192639.GC32240@kernel.org>
On Thu, Mar 7, 2019 at 11:26 AM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Thu, Mar 07, 2019 at 08:09:39PM +0100, Peter Zijlstra escreveu:
> > On Thu, Mar 07, 2019 at 04:03:30PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Mar 07, 2019 at 10:52:33AM -0800, Stephane Eranian escreveu:
> > > > On mmap(), perf_events generates a RECORD_MMAP record and then checks
> > > > which events are interested in this record. There are currently 2 versions
> > > > of mmap records: RECORD_MMAP and RECORD_MMAP2. MMAP2 is larger. The event
> > > > configuration controls which version the user level tool accepts. If the
> > > > event->attr.mmap2=1 field then MMAP2 record is returned. The
> > > > perf_event_mmap_output() takes care of this. It checks attr->mmap2 and corrects
> > > > the record fields before putting it in the sampling buffer of the event.
> > > > At the end the function restores the modified MMAP record fields.
>
> > > > The problem is that the function restores the size but not the
> > > > type. Thus, if a subsequent event only accepts MMAP type, then it would
> > > > instead receive an MMAP2 record with a size of MMAP record.
>
> > > > This patch fixes the problem by restoring the record type on exit.
>
> > > Right, simple enough, bug fixed, Peter, I'm taking this one, ok?
>
> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>
> BTW, added:
>
> Fixes: 13d7a2410fa6 ("perf: Add attr->mmap2 attribute to an event")
>
> For the stable guys to pick this up. Please try to add the fixes tag in
> the future.
Ok, thanks.
>
>
> Thanks,
>
> - Arnaldo
next prev parent reply other threads:[~2019-03-07 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 18:52 [PATCH] perf/core: restore mmap record type correctly Stephane Eranian
2019-03-07 19:03 ` Arnaldo Carvalho de Melo
2019-03-07 19:09 ` Peter Zijlstra
2019-03-07 19:26 ` Arnaldo Carvalho de Melo
2019-03-07 19:28 ` Stephane Eranian [this message]
2019-03-22 21:58 ` [tip:perf/urgent] perf/core: Restore " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPqkBTXAfYr4XkeFfUWBg9ygW2abWxmH79y9E-DbqLofS+mjw@mail.gmail.com \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).