From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2D7AC282C4 for ; Mon, 4 Feb 2019 20:05:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EB1220821 for ; Mon, 4 Feb 2019 20:05:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TVycT1vD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbfBDUFw (ORCPT ); Mon, 4 Feb 2019 15:05:52 -0500 Received: from mail-vk1-f195.google.com ([209.85.221.195]:34298 "EHLO mail-vk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727245AbfBDUFw (ORCPT ); Mon, 4 Feb 2019 15:05:52 -0500 Received: by mail-vk1-f195.google.com with SMTP id y14so284825vkd.1 for ; Mon, 04 Feb 2019 12:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H5IYKG4bB2NjlZivlIRZEZg+5APtAY6rXApLSvgBmaI=; b=TVycT1vD+o6/ViI3X3B0JOvxIQ9gqKmz5abOxwf5UbhwLO5rGE6UYnrYTbjZeWE0/L GG2sZP3giWMQABGgA3XiuaZAUcrHSf3h/xaevifk1PCdIIsEgap7rWj5WU93to5F/3aY wUaAcbpP0Eupot0oUJCmzaMmAVV4Eq0sA41GfaXDk449MMhk3+ZQPiHQyeH0j2CYhNBy hximtQkf1pbJB+ykoJ61xzyyw9MpCLNECPeBTbZdXMjXF3tEdcgzllH1R5OIcOcvIVnq i25yE1h5NwrNK0oM5t/q1e5H5lPqH6/jA8nF3OqtQKJB/wBmOxezbjBYLnrcs9HY5/Z3 WohQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H5IYKG4bB2NjlZivlIRZEZg+5APtAY6rXApLSvgBmaI=; b=atiZZDCj4QhymW3BAewGdwWbfZCd21+sGmBUx0zkSBjeI0TbVSYMmNtXNvX0LeLRvp EgFTi8fPaUS3bmBOnbOOAkySLSGvXkN4Mt8AuXr+7lLEmjyzlV9ENmukV9ICr/msayks wBf1W4l4y93TkcvasoJoz+9GgvgQcdxXRxjXtSjlWgFkNLkW0wOJPkLVz612hWvUmSKB cQJeP1TerHWKzFWYWATHcCL2EEHM5w2cLgJsSKbGfH8xs7i1ncaqTZdPRo4dsY0THHrN KlA6bu0d0HJ3rXTf6i3PmiURn7HcE+3pjfDwnLI93UytvK3BPwScoSECYtYsg8NjZ4QJ i1zA== X-Gm-Message-State: AHQUAuY7vbMqNtc8OxOChiwfuq3iSn9M/KXSUha5pFScDDD7A42YzXID 97rut5nirznOOwEkfiAGnwcwOyfeGHTJSH/ZVJWSVA== X-Google-Smtp-Source: AHgI3IbrxD1Xszvm/uW+bBMHPDlkkDzETqpNGG15ld3UciazBuVEVYzM01K0ER2XuX3/wgSiiMdr13883ZQmKZuNAhM= X-Received: by 2002:a1f:a147:: with SMTP id k68mr481479vke.1.1549310750531; Mon, 04 Feb 2019 12:05:50 -0800 (PST) MIME-Version: 1.0 References: <20190203153018.9650-1-jolsa@kernel.org> <8d8b3f0d-cea8-2daf-249f-29f485c49a46@linux.intel.com> <20190204103643.GA18141@krava> <6bf24b7d-2bd3-8091-cf49-363c91e4e864@linux.intel.com> <20190204114144.GC18141@krava> <20190204192721.GI5593@kernel.org> In-Reply-To: <20190204192721.GI5593@kernel.org> From: Stephane Eranian Date: Mon, 4 Feb 2019 12:05:38 -0800 Message-ID: Subject: Re: [RFC/PATCH 00/14] perf record: Add support to store data in directory To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Alexey Budankov , Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Adrian Hunter , Andi Kleen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 4, 2019 at 11:27 AM Arnaldo Carvalho de Melo wrote: > > Em Mon, Feb 04, 2019 at 10:56:05AM -0800, Stephane Eranian escreveu: > > On Mon, Feb 4, 2019 at 3:41 AM Jiri Olsa wrote: > > > > > > On Mon, Feb 04, 2019 at 02:29:56PM +0300, Alexey Budankov wrote: > > > > On 04.02.2019 13:36, Jiri Olsa wrote: > > > > > On Mon, Feb 04, 2019 at 01:12:11PM +0300, Alexey Budankov wrote: > > > > >> > > > > >> Hi, > > > > >> > > > > >> On 03.02.2019 18:30, Jiri Olsa wrote: > > > > >>> hi, > > > > >>> this patchset adds the --dir option to record command (and all > > > > >>> the other record command that overload cmd_record) that allows > > > > >>> the data to be stored in directory with multiple data files. > > > > >>> > > > > >>> It's next step for multiple threads implementation in record. > > > > >>> It's now possible to make directory data via --dir option, like: > > > > >>> > > > > >>> $ perf record --dir perf bench sched messaging > > > > >> > > > > >> Is it possible to name data directory differently from perf.data > > > > >> e.g. using --output option, like this? > > > > >> > > > > >> $ perf record --output result_1 --dir perf bench sched messaging > > > > > > > > > > > > > > > yep, it's taken into account: > > > > > > > > > > [jolsa@krava perf]$ ./perf record --output result_1 --dir ./perf bench sched messaging > > > > > Couldn't synthesize bpf events. > > > > > # Running 'sched/messaging' benchmark: > > > > > # 20 sender and receiver processes per group > > > > > # 10 groups == 400 processes run > > > > > > > > > > Total time: 0.177 [sec] > > > > > [ perf record: Woken up 1 times to write data ] > > > > > [ perf record: Captured and wrote 0.316 MB result_1 (7225 samples) ] > > > > > > > > > > [jolsa@krava perf]$ ll result_1/ > > > > > total 348 > > > > > -rw-------. 1 jolsa jolsa 27624 Feb 4 11:35 data.0 > > > > > -rw-------. 1 jolsa jolsa 56672 Feb 4 11:35 data.1 > > > > > -rw-------. 1 jolsa jolsa 30824 Feb 4 11:35 data.2 > > > > > -rw-------. 1 jolsa jolsa 49136 Feb 4 11:35 data.3 > > > > > -rw-------. 1 jolsa jolsa 22712 Feb 4 11:35 data.4 > > > > > -rw-------. 1 jolsa jolsa 53392 Feb 4 11:35 data.5 > > > > > -rw-------. 1 jolsa jolsa 43352 Feb 4 11:35 data.6 > > > > > -rw-------. 1 jolsa jolsa 46688 Feb 4 11:35 data.7 > > > > > -rw-------. 1 jolsa jolsa 9068 Feb 4 11:35 header > > > > > > > > Awesome. What do you think about having it like this: > > > > > > > > $ perf record --output result_1.data ... - writes data to a file > > > > > > > > $ perf record --dir result_1 ... - or even > > > > $ perf record --output_dir result_1 ... - writes data into a directory > > > > > > > > IMHO, this interface is simpler for a user. > > > > > > yep, seems more convenient.. I'll add it > > > > > But what happens if you do: perf record -o foo --output_dir foo.d? > > Should fail, i.e. either you use single-file or directory output, I > think. > Agreed > - Arnaldo