From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71490C433B4 for ; Wed, 14 Apr 2021 10:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 398A56105A for ; Wed, 14 Apr 2021 10:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234833AbhDNK5U (ORCPT ); Wed, 14 Apr 2021 06:57:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234570AbhDNK5S (ORCPT ); Wed, 14 Apr 2021 06:57:18 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99A50C061756 for ; Wed, 14 Apr 2021 03:56:57 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id v26so20211656iox.11 for ; Wed, 14 Apr 2021 03:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xJdZSbHTyMBCsVp7BAaTCxdXi6B0tpl9od8+wlQ9J+g=; b=TEAgfFBFUB3b0fB+QOyjxFBwYw0U5RxeWNc26RxJa8ik23iALaiCaRngy5LMzw9L8o ngDCjNrtS7pw5RNK5LCLafOfxKX5DMh1H3zLWoCqWVa9aaP7xk6xhD22vEEhdjO/3zMq 4tbPUaynT31cZgfRtXvFhfpcpcSWqp//AzYq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xJdZSbHTyMBCsVp7BAaTCxdXi6B0tpl9od8+wlQ9J+g=; b=GdpzSmCInUpHcOlfWsV+yX15iCq0gSaEu6PJmLyCrrB+ic4jk/8cPKHH5pFuBSFN0z RkbewqzwkUIF3DrW6YqHwmU9+PMB04M9Df9YEbpSTbpRgd2myxAVgztEwIYn3lTxkGK1 0/Tt40mgjLxWC+3rxzvlo0oWcvtTnYPyRc+kl+NNrsUMilKBlfIkOtvQWE9pp+TELRQA EvKQDuduwqdgbK5nEnTim7TsvgryVkHYaM0NqM7Qc12nrMvmG5l6EPuSKd9RQl8b63P7 7pL0J5eLKN1sLeMGGlkJ4Rccf/0yuM4cvEseaYlkSY5VAd4dQcNMBykTV207wQHIMO8T tm7A== X-Gm-Message-State: AOAM532vD9pqRz875H7r7h2jZwhLEKvTrd8WMjAnygC4P9FHE/BvZUJx Jj+TzuOWi4tjX0DsBk0fzNba9TmQBnvcc1LbXdSrBulU3Lc= X-Google-Smtp-Source: ABdhPJzbOpygaeq8A7GMJvLn+Om67N8hLLaO1CKhbeDgYPkDMIxrniuJJUuaib3hhaIExfwv2HbHOYjtPypZ2p0Mt3M= X-Received: by 2002:a02:b197:: with SMTP id t23mr37906352jah.125.1618397816954; Wed, 14 Apr 2021 03:56:56 -0700 (PDT) MIME-Version: 1.0 References: <20210412153754.235500-1-revest@chromium.org> <20210412153754.235500-2-revest@chromium.org> In-Reply-To: From: Florent Revest Date: Wed, 14 Apr 2021 12:56:46 +0200 Message-ID: Subject: Re: [PATCH bpf-next v3 1/6] bpf: Factorize bpf_trace_printk and bpf_seq_printf To: Andrii Nakryiko Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Yonghong Song , KP Singh , Brendan Jackman , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2021 at 11:56 AM Florent Revest wrote: > On Wed, Apr 14, 2021 at 1:01 AM Andrii Nakryiko > wrote: > > On Mon, Apr 12, 2021 at 8:38 AM Florent Revest wrote: > > > + err = 0; > > > +out: > > > + put_fmt_tmp_buf(); > > > > so you are putting tmp_buf unconditionally, even when there was no > > error. That seems wrong? Should this be: > > > > if (err) > > put_fmt_tmp_buf() > > > > ? > > Yeah the naming is unfortunate, as discussed in the other patch, I > will rename that to bpf_pintf_cleanup instead. It's not clear from the > name that it only "puts" if the buffer was already gotten. Ah, sorry I see what you meant! Indeed, my mistake. :|