From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4CFC4743D for ; Sun, 6 Jun 2021 00:55:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D0DE61415 for ; Sun, 6 Jun 2021 00:55:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhFFA4a (ORCPT ); Sat, 5 Jun 2021 20:56:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbhFFA4a (ORCPT ); Sat, 5 Jun 2021 20:56:30 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 275FCC061767 for ; Sat, 5 Jun 2021 17:54:26 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id h22-20020a05600c3516b02901a826f84095so2785484wmq.5 for ; Sat, 05 Jun 2021 17:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3DxaiNSkw+eA+wXHpN2KP+oFrvWPJdQHdeQTKj9QQeM=; b=lUQyRaiq4AaXZaYWlH94S6Gn12mM38lNqlot8GXQItBQd53hfwyniIc3wxruyGl52c qPJLxMg+MoWiZ5jxmbF5hdBJ0Wvgggv/tFbZ+2Fn4ANbufSO58IbuYYcDgbbe4vDDX2P kbnBXtL3XwrbRdOHZJ8gHyqoVnMFfhcrCBGcPNdw/n8FjfvikX4oKWGwKskfOUwe8WBe eY4ffJ10mJ1mC6rgIn2BQTY+jdFPgpnyGZQWMUXuIdqBH1ZwekIsaGPm6I/c2ARSmmIZ 4dV9ZkZ4E37cKxXXaN+tJdcdKMDDzKGC8Qadioa+J6X17wG7PJv+GhknTR8sHhSoIzcO GPRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3DxaiNSkw+eA+wXHpN2KP+oFrvWPJdQHdeQTKj9QQeM=; b=CsJeceZ5cVOQSYOK0d6wHqZ+vNZjHhdJDAeudZIwsSZONq6Zh7ft4vhr/60iz0w85c 7yRUOl/jXAEoytwNBSRVyK4yHkz5SkqW4WYdNP90MmaR95sERVz9f0KSRvHNcy1ihG51 5ySrcvRgOSzgpr3COZHnq874NIYJo3e/e2Gv1Pam3Z1z9qqmJeu8QI2QrayG3Nqk9it2 LH2uIQy0zLrcP9yMaUXI7IZ2JMNN/7Csz0sPjonl3rfL1KG+TIaC6c784sdqUr6t6tw+ ZBdaU1rghEHdQZCeYlAVsaKnqorFDu0xdAxZYUYBVkIGpylmyvRqNoLjwKVlHrnz5Mam YQKA== X-Gm-Message-State: AOAM5318du+Lv3JA2b4CyHcB3XXC8/jWJlS4Bol2vEKKBjJ71P4Qgza+ hDg+RyoP2dQ3qDOVSAkoAx0Xd3iJi5/eEu7ZUBj24g== X-Google-Smtp-Source: ABdhPJxW3B5oI9ev63JTOffeqEWrYZWrYU5sFyNrebXusVFcqbrVZAViyfqSDs3CtmbFkC5ZdBVCMuWtumEoQzrBCjQ= X-Received: by 2002:a7b:c44f:: with SMTP id l15mr10268090wmi.151.1622940864731; Sat, 05 Jun 2021 17:54:24 -0700 (PDT) MIME-Version: 1.0 References: <20210605215215.171165-1-andrealmeid@collabora.com> In-Reply-To: <20210605215215.171165-1-andrealmeid@collabora.com> From: David Gow Date: Sun, 6 Jun 2021 08:54:13 +0800 Message-ID: Subject: Re: [PATCH] lib: Convert UUID runtime test to KUnit To: =?UTF-8?Q?Andr=C3=A9_Almeida?= Cc: Christoph Hellwig , Andy Shevchenko , Linux Kernel Mailing List , Brendan Higgins , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Shuah Khan , ~lkcamp/patches@lists.sr.ht, nfraprado@collabora.com, leandro.ribeiro@collabora.com, Vitor Massaru Iha , lucmaga@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 6, 2021 at 5:52 AM Andr=C3=A9 Almeida wrote: > > Remove custom functions for testing and use KUnit framework. Test cases > and test data remains the same. > > Signed-off-by: Andr=C3=A9 Almeida > --- Thanks! It's always exciting to see more tests using KUnit. Note that the names here (filename, suite name, and Kconfig entry name) don't match what we usually recommend for KUnit tests: https://www.kernel.org/doc/html/latest/dev-tools/kunit/style.html Given that this is an existing test, it is definitely okay to keep the old names if you think it'd break something, but if there's no issue it may be worth renaming them. The test suite name (which is new anyway) ideally shouldn't end in "-test": just "uuid" is best. I know there are quite a few existing tests which don't adhere to these perfectly yet, but ideally new ones will if it's convenient. Otherwise, this looks great. I've run it here, and it worked well and picked up on any deliberate errors I introduced. So this is Tested-by: David Gow Cheers, -- David