From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D86DC433B4 for ; Tue, 18 May 2021 04:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69FA260E08 for ; Tue, 18 May 2021 04:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344220AbhEREaz (ORCPT ); Tue, 18 May 2021 00:30:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242723AbhEREax (ORCPT ); Tue, 18 May 2021 00:30:53 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59FF2C061756 for ; Mon, 17 May 2021 21:29:35 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id v12so8573053wrq.6 for ; Mon, 17 May 2021 21:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IYivGhbkgN/0kOX9moGua2NF+G4pIWkoseKbkugbZk8=; b=b/QzFYlSCIrp2x7Ol1KR9fZeYmrh9fuQnORQMISfz94c4LGcCztOQE+joRIa/yDCvm S6KZQhefd9EsRZUSyi9v9GDwzs4U/UMjeFz1Q0xM9W3W8q6UAbre3ZSENZKRgKY0qf/L OHE6Isb5ZXUK8zDPXLpLv/nQSMqznz4rsAmnfR+ilt9ju4kumWfbm2KIa1+ug3Jm04S1 cSmQTjvsI35Hauy72QZNRZJ8ZDh+KihfuTUtWWGhY3j4NUkOkh2mGY8J+zj99l6Fm/mg EfOQ93cGSGKpLzytWUn5d7vN8Y7xZTxBoV7lO6XHMbA4+vEEeOHinXYmk2nhWOiSkmb1 /fkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IYivGhbkgN/0kOX9moGua2NF+G4pIWkoseKbkugbZk8=; b=NKzCbMSFDuOiGqPQ6Vn3YytTu1FWrfX1Rh/reerMsZ0FrzPqrGSVJE6XqRI/Jz9ee7 jb9/3IVqxWTy/+g7n+qW56bpLOJcht4SZfKV6X50eXNXdt8cRJJARyuffZqV4vJFISHK E5p+Bc5Bf20/zROX8KJfaHt/HWk7WCTBsou7qAdigbMetVpw1js+HYEnvNfvMDssrcDM oP0tfGo2VmZi9hoUqHXgTrMmdT8FOM0Nk1isfqRWXNz76BeytaI6W0djBUzxL50bNrOt btoUWBLgp7Pd9Jc8Ot3OHPciEpm/iRyvu19wzB77RT8auSNTQnbQMNDRr6ur3Q+Upw5w pDCw== X-Gm-Message-State: AOAM531i0srrla5FPYCUrVWmEyNK/XZ2olsZgC4BMDmo4RL4t9WNKBBc +JMy9iTfC0JdOzJGIYRz0vv1YEdLkAvH9oUK1JUPtg== X-Google-Smtp-Source: ABdhPJz73C/JeMEY7R3wJhYkQwIiUPW6qbsA6Exu7snYht6lCDkBlkpzGwS739hPzgZX0IvEs+sGHHVFeJ+yjoeM/7g= X-Received: by 2002:a05:6000:1147:: with SMTP id d7mr4151974wrx.302.1621312173995; Mon, 17 May 2021 21:29:33 -0700 (PDT) MIME-Version: 1.0 References: <20210513193204.816681-1-davidgow@google.com> <20210513193204.816681-6-davidgow@google.com> In-Reply-To: From: David Gow Date: Tue, 18 May 2021 12:29:22 +0800 Message-ID: Subject: Re: [PATCH v2 06/10] mmc: sdhci-of-aspeed: Remove some unnecessary casts from KUnit tests To: Ulf Hansson Cc: Brendan Higgins , Daniel Latypov , Shuah Khan , Andrew Jeffery , Adrian Hunter , Joel Stanley , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , linux-mmc , linux-aspeed , OpenBMC Maillist , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 5:23 PM Ulf Hansson wrote: > > On Thu, 13 May 2021 at 21:36, David Gow wrote: > > > > With KUnit's EXPECT macros no longer typechecking arguments as strictly, > > get rid of a number of now unnecessary casts. > > > > Signed-off-by: David Gow > > I guess you will funnel this via another tree than the mmc? > > Acked-by: Ulf Hansson > > Kind regards > Uffe > Yeah: the plan is to have this whole series go through the kselftest/kunit tree so we don't have to worry about potentially temporarily introducing a bunch of compiler warnings. Cheers, -- David > > --- > > This should be a no-op functionality wise, and while it depends on the > > first couple of patches in this series, it's otherwise independent from > > the others. I think this makes the test more readable, but if you > > particularly dislike it, I'm happy to drop it. > > > > drivers/mmc/host/sdhci-of-aspeed-test.c | 34 ++++++++++++------------- > > 1 file changed, 17 insertions(+), 17 deletions(-) > > > > diff --git a/drivers/mmc/host/sdhci-of-aspeed-test.c b/drivers/mmc/host/sdhci-of-aspeed-test.c > > index bb67d159b7d8..1ed4f86291f2 100644 > > --- a/drivers/mmc/host/sdhci-of-aspeed-test.c > > +++ b/drivers/mmc/host/sdhci-of-aspeed-test.c > > @@ -26,23 +26,23 @@ static void aspeed_sdhci_phase_ddr52(struct kunit *test) > > KUNIT_EXPECT_EQ(test, 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 25)); > > > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > > aspeed_sdhci_phase_to_tap(NULL, rate, 180)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > > aspeed_sdhci_phase_to_tap(NULL, rate, 181)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > aspeed_sdhci_phase_to_tap(NULL, rate, 182)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > aspeed_sdhci_phase_to_tap(NULL, rate, 183)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 2, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 2, > > aspeed_sdhci_phase_to_tap(NULL, rate, 184)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 3, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 3, > > aspeed_sdhci_phase_to_tap(NULL, rate, 185)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > > aspeed_sdhci_phase_to_tap(NULL, rate, 203)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 204)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 205)); > > } > > > > @@ -67,21 +67,21 @@ static void aspeed_sdhci_phase_hs200(struct kunit *test) > > KUNIT_EXPECT_EQ(test, 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 96)); > > > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > > aspeed_sdhci_phase_to_tap(NULL, rate, 180)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > > aspeed_sdhci_phase_to_tap(NULL, rate, 185)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > aspeed_sdhci_phase_to_tap(NULL, rate, 186)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > aspeed_sdhci_phase_to_tap(NULL, rate, 187)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > > aspeed_sdhci_phase_to_tap(NULL, rate, 269)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 270)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 271)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 276)); > > } > > > > -- > > 2.31.1.751.gd2f1c929bd-goog > >