From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE2EDC433DF for ; Sat, 8 Aug 2020 03:27:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79F042086A for ; Sat, 8 Aug 2020 03:27:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mYnRitoD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbgHHD1N (ORCPT ); Fri, 7 Aug 2020 23:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726335AbgHHD1M (ORCPT ); Fri, 7 Aug 2020 23:27:12 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE07C061A27 for ; Fri, 7 Aug 2020 20:27:11 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id x5so3245978wmi.2 for ; Fri, 07 Aug 2020 20:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I0+G3ptAFziJUCT/18IT+zTZUcvz/66QmwQnq2ejpjY=; b=mYnRitoDRGnzQN5IFjn015NCM7g2pLzAdf/7p6ZdrQx/OZGSwtTuIcuSgnz7+nu9qV 001Ha2HBxKk0gYPBhkU4do6oqaBVe/QAUkugEKVFaXDXfgCwMPPNwxSyWTpF31XIGv6g w9Sa4cCCVlwvWleQ2RvEPwef/DsQNAiP2l7ZlCuUSBVORaQbR1ftz5+Uam5eppvGlSIv 3MyOGkU/t+SVW8AnGBGLr3lyjyzpEoVU25kDagRiNUIox7awXGG4LRwAu9vLy7lpuWdU DBKFgsu7poteX4PQ3XPBm0YaXf/ayyykY6ANb5KLmMTpgHQv1ITJZHhRa5ZxHV3RhM5f ocLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I0+G3ptAFziJUCT/18IT+zTZUcvz/66QmwQnq2ejpjY=; b=hR+xak/hQLwJwdO2EyEmTq6T5zrHeTwhQFfPKVdFck0+LEiCgEBBbGOilZNeqEZPOG UFqqp/RbtoxAW8Jjocuj9c4Y1Bc20ndftutjr8mkjwE3qSZeLV7ui3RYk6WC0YY+kqg5 BW92882s0ski7Y5rMVYO30nEesw6Pkaz2juszEoi37/3I1WupsZmNyzHKM09jG9hDO47 gMFyj/ZiOTFAzaDfM1GlRM8hbTlRUHJr541NkoaPlOsEaX415x2PzVVJ72NwHgSAgi21 WF0YOZ27p4YWmVM6NZDpvc0oAJREyTs8IxV0H6iVC0NouSix+h7wFWt2oeRblUCXVaaI YIBA== X-Gm-Message-State: AOAM533vJBdSpYSUR/8TYZnSoOGAO/kyKaJ5m+H3V+bJsPJz2FYLbPIu Tt9d8UFjtR0wvSo3WvTANKcA9lZat8xA2Qu3oMny6w== X-Google-Smtp-Source: ABdhPJz8N3755lj1ooAtGAlEW8uOvjNdG465PnUVZXEXiUy+efXsmC2Szc6kDxhz8ShLf8f0C3GbzgPJOCRyJSIYN10= X-Received: by 2002:a1c:2485:: with SMTP id k127mr14768659wmk.138.1596857230126; Fri, 07 Aug 2020 20:27:10 -0700 (PDT) MIME-Version: 1.0 References: <20200805042938.2961494-1-davidgow@google.com> In-Reply-To: From: David Gow Date: Sat, 8 Aug 2020 11:26:58 +0800 Message-ID: Subject: Re: [PATCH v11 0/6] KASAN-KUnit Integration To: Andrey Konovalov Cc: Andrew Morton , Patricia Alfonso , Brendan Higgins , Andrey Ryabinin , Dmitry Vyukov , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Shuah Khan , LKML , kasan-dev , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 7, 2020 at 9:15 PM 'Andrey Konovalov' via kasan-dev wrote: > > On Wed, Aug 5, 2020 at 6:29 AM David Gow wrote: > > > > This patchset contains everything needed to integrate KASAN and KUnit. > > > > KUnit will be able to: > > (1) Fail tests when an unexpected KASAN error occurs > > (2) Pass tests when an expected KASAN error occurs > > > > Convert KASAN tests to KUnit with the exception of copy_user_test > > because KUnit is unable to test those. > > > > Add documentation on how to run the KASAN tests with KUnit and what to > > expect when running these tests. > > > > This patchset depends on: > > - "kunit: extend kunit resources API" [1] > > - This is included in the KUnit 5.9-rci pull request[8] > > > > I'd _really_ like to get this into 5.9 if possible: we also have some > > other changes which depend on some things here. > > Found a small issue in patch #3, but otherwise: > > Tested-by: Andrey Konovalov > > for the series. Cheers! The issue in #3 looks to be a rebase issue: I'll send a fixed version out soon. > > The patches apply cleanly on top of the latest linux-next/akpm branch. > > There are some tests that fail for tag-based mode, but those are > unrelated to this series, and require KASAN improvements. > Do you think it's worth disabling these tests if tag-based mode is disabled? Personally, I'm leaning "no", but if the planned support for explicitly skipping tests existed, this could be a good case for it: a test which is expected to fail due to a feature not existing in the current config. Thanks, -- David > > > > Changes from v10: > > - Fixed some whitespace issues in patch 2. > > - Split out the renaming of the KUnit test suite into a separate patch. > > > > Changes from v9: > > - Rebased on top of linux-next (20200731) + kselftest/kunit and [7] > > - Note that the kasan_rcu_uaf test has not been ported to KUnit, and > > remains in test_kasan_module. This is because: > > (a) KUnit's expect failure will not check if the RCU stacktraces > > show. > > (b) KUnit is unable to link the failure to the test, as it occurs in > > an RCU callback. > > > > Changes from v8: > > - Rebased on top of kselftest/kunit > > - (Which, with this patchset, should rebase cleanly on 5.8-rc7) > > - Renamed the KUnit test suite, config name to patch the proposed > > naming guidelines for KUnit tests[6] > > > > Changes from v7: > > - Rebased on top of kselftest/kunit > > - Rebased on top of v4 of the kunit resources API[1] > > - Rebased on top of v4 of the FORTIFY_SOURCE fix[2,3,4] > > - Updated the Kconfig entry to support KUNIT_ALL_TESTS > > > > Changes from v6: > > - Rebased on top of kselftest/kunit > > - Rebased on top of Daniel Axtens' fix for FORTIFY_SOURCE > > incompatibilites [2] > > - Removed a redundant report_enabled() check. > > - Fixed some places with out of date Kconfig names in the > > documentation. > > > > Changes from v5: > > - Split out the panic_on_warn changes to a separate patch. > > - Fix documentation to fewer to the new Kconfig names. > > - Fix some changes which were in the wrong patch. > > - Rebase on top of kselftest/kunit (currently identical to 5.7-rc1) > > > > Changes from v4: > > - KASAN no longer will panic on errors if both panic_on_warn and > > kasan_multishot are enabled. > > - As a result, the KASAN tests will no-longer disable panic_on_warn. > > - This also means panic_on_warn no-longer needs to be exported. > > - The use of temporary "kasan_data" variables has been cleaned up > > somewhat. > > - A potential refcount/resource leak should multiple KASAN errors > > appear during an assertion was fixed. > > - Some wording changes to the KASAN test Kconfig entries. > > > > Changes from v3: > > - KUNIT_SET_KASAN_DATA and KUNIT_DO_EXPECT_KASAN_FAIL have been > > combined and included in KUNIT_DO_EXPECT_KASAN_FAIL() instead. > > - Reordered logic in kasan_update_kunit_status() in report.c to be > > easier to read. > > - Added comment to not use the name "kasan_data" for any kunit tests > > outside of KUNIT_EXPECT_KASAN_FAIL(). > > > > Changes since v2: > > - Due to Alan's changes in [1], KUnit can be built as a module. > > - The name of the tests that could not be run with KUnit has been > > changed to be more generic: test_kasan_module. > > - Documentation on how to run the new KASAN tests and what to expect > > when running them has been added. > > - Some variables and functions are now static. > > - Now save/restore panic_on_warn in a similar way to kasan_multi_shot > > and renamed the init/exit functions to be more generic to accommodate. > > - Due to [4] in kasan_strings, kasan_memchr, and > > kasan_memcmp will fail if CONFIG_AMD_MEM_ENCRYPT is enabled so return > > early and print message explaining this circumstance. > > - Changed preprocessor checks to C checks where applicable. > > > > Changes since v1: > > - Make use of Alan Maguire's suggestion to use his patch that allows > > static resources for integration instead of adding a new attribute to > > the kunit struct > > - All KUNIT_EXPECT_KASAN_FAIL statements are local to each test > > - The definition of KUNIT_EXPECT_KASAN_FAIL is local to the > > test_kasan.c file since it seems this is the only place this will > > be used. > > - Integration relies on KUnit being builtin > > - copy_user_test has been separated into its own file since KUnit > > is unable to test these. This can be run as a module just as before, > > using CONFIG_TEST_KASAN_USER > > - The addition to the current task has been separated into its own > > patch as this is a significant enough change to be on its own. > > > > > > [1] https://lore.kernel.org/linux-kselftest/CAFd5g46Uu_5TG89uOm0Dj5CMq+11cwjBnsd-k_CVy6bQUeU4Jw@mail.gmail.com/T/#t > > [2] https://lore.kernel.org/linux-mm/20200424145521.8203-1-dja@axtens.net/ > > [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=adb72ae1915db28f934e9e02c18bfcea2f3ed3b7 > > [4] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=47227d27e2fcb01a9e8f5958d8997cf47a820afc > > [5] https://bugzilla.kernel.org/show_bug.cgi?id=206337 > > [6] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@google.com/ > > [7] https://lkml.org/lkml/2020/7/31/571 > > [8] https://lore.kernel.org/linux-kselftest/8d43e88e-1356-cd63-9152-209b81b16746@linuxfoundation.org/T/#u > > > > > > David Gow (2): > > kasan: test: Make KASAN KUnit test comply with naming guidelines > > mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set > > > > Patricia Alfonso (4): > > Add KUnit Struct to Current Task > > KUnit: KASAN Integration > > KASAN: Port KASAN Tests to KUnit > > KASAN: Testing Documentation > > > > Documentation/dev-tools/kasan.rst | 70 +++ > > include/kunit/test.h | 5 + > > include/linux/kasan.h | 6 + > > include/linux/sched.h | 4 + > > lib/Kconfig.kasan | 22 +- > > lib/Makefile | 7 +- > > lib/kasan_kunit.c | 770 +++++++++++++++++++++++++ > > lib/kunit/test.c | 13 +- > > lib/test_kasan.c | 903 ------------------------------ > > lib/test_kasan_module.c | 111 ++++ > > mm/kasan/report.c | 34 +- > > 11 files changed, 1028 insertions(+), 917 deletions(-) > > create mode 100644 lib/kasan_kunit.c > > delete mode 100644 lib/test_kasan.c > > create mode 100644 lib/test_kasan_module.c > > > > -- > > 2.28.0.163.g6104cc2f0b6-goog > > > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/CAAeHK%2BwPt46879AnV3n3d7%2BJZqkv2Vo652OPBAjHcuyru56h9w%40mail.gmail.com.