From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B807C4361A for ; Fri, 4 Dec 2020 04:17:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE32822472 for ; Fri, 4 Dec 2020 04:17:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727589AbgLDERv (ORCPT ); Thu, 3 Dec 2020 23:17:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbgLDERu (ORCPT ); Thu, 3 Dec 2020 23:17:50 -0500 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64F24C061A51 for ; Thu, 3 Dec 2020 20:17:10 -0800 (PST) Received: by mail-lf1-x141.google.com with SMTP id a9so5912236lfh.2 for ; Thu, 03 Dec 2020 20:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oqbYgHoyRpSXCyJ6D915vmzlzKvUWRldO8k4oJpM0AQ=; b=PTXeh+y1BZR7RngQCYoV6fWKQ0zeI9y7rHS64cHX8wi9aNY5DVvHBblOuSDkFkJQoO K19eCEO/WfOK6hEOuReM2KiRIBBUgJwhHcZM4gyZ4XiqYEUZUdMBty+98ryea0v1zI7A dknR8EVb2niIz//e1tS5HPWK/wKcs6FaG+11GVs6khUhexlGIoestI8h0/LgNvMAK8qt ldrwkYY6mipndHTsVwJ0eDNxDloI1XWCtBGFLGB1E/lYWhXmDTSXRnUXm8aNFpVTIc65 mS7bbVIZcMvedCkGBQ3pEvJWu2tDNWYpEniH8xiD2s/5q11Y3w7OzUtsZz+x3h1+z/ZP eX3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oqbYgHoyRpSXCyJ6D915vmzlzKvUWRldO8k4oJpM0AQ=; b=mop6rQ+1FK7LqDB9b974ThCZLV6ETLtxVRQ6ZsaOsQ4ao0bXvL38p5Jd+znpotFObT sZYKMetRrBxCDdPOxtMBgWgybARtheXttR/Rj7Q+I8LgTvizDTFNP/f0KmjlZjvDY7dR 8Q5mVdaPDlIYYuZqzod5qhHd6Ol/87Y+yjoGNxiPHky5bNW6BYVHr0jWzjq91yL8+/GM pWIfoJtPisLxRLJTjkQAhHEMtWLOCJrUWoiU04rNjyOrOY9umPLXTVzmsSEdael3N289 4ahGAYnKW2KRvfHCgk0K+EvOdN95e/+h9tV+voF2ipve2MKVfvKy7gFSVcXWJL48rHuS 4UyA== X-Gm-Message-State: AOAM531XDEt84M2eIAB3DDQAPWFFD/Ir8PsIgyV1p3npkeVC7GErowgI 7y5vNCNjkY4CrphPOEQPx19q1i7lq8+8fcLJgsoPcXjn6UG8od6k X-Google-Smtp-Source: ABdhPJxiOKO/A2wEfl8X75fUSGui4pNH+ob3iIIVIjIoBc46Asnf4hEPl43PB4peXdOK1wKtxq1bidSt42t0tPcJSfc= X-Received: by 2002:a19:5e5e:: with SMTP id z30mr2518792lfi.277.1607055428578; Thu, 03 Dec 2020 20:17:08 -0800 (PST) MIME-Version: 1.0 References: <20201203194127.1813731-1-dlatypov@google.com> <20201203194127.1813731-2-dlatypov@google.com> In-Reply-To: <20201203194127.1813731-2-dlatypov@google.com> From: David Gow Date: Fri, 4 Dec 2020 12:16:56 +0800 Message-ID: Subject: Re: [PATCH 2/3] kunit: tool: fix minor typing issue with None status To: Daniel Latypov Cc: Brendan Higgins , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote: > This seems good to me, but I have a few questions, particularly around the description. > The code to handle aggregating statuses didn't check that the status > actually got set. I don't understand what you mean here. Does this refer to Test{Case,Suite}::status potentially being None, and that not being supported properly in bubble_up_{suite_,test_case_,}errors(), or something else? Either way, I can't see any additional code to "check" that the status has been set. As far as I can tell everything except the default to SUCCESS is a no-op, or am I missing something? > Default the value to SUCCESS. I'm a little iffy about defaulting this to success, but I think it's okay for now: the skip test support will eventually change this to a SKIPPED value. > > This sorta follows the precedent in commit 3fc48259d525 ("kunit: Don't > fail test suites if one of them is empty"). > > Also slightly simplify the code and add type annotations. > > Signed-off-by: Daniel Latypov > --- Otherwise, the actual code changes all seem sensible, and it worked fine when I tested it, so: Reviewed-by: David Gow -- David