From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20BA1C63699 for ; Sat, 14 Nov 2020 03:18:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB41122245 for ; Sat, 14 Nov 2020 03:18:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="V7otNblM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726387AbgKNDRx (ORCPT ); Fri, 13 Nov 2020 22:17:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726319AbgKNDRx (ORCPT ); Fri, 13 Nov 2020 22:17:53 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 725ECC0617A6 for ; Fri, 13 Nov 2020 19:17:51 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id s30so17100006lfc.4 for ; Fri, 13 Nov 2020 19:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=toERlzzL8WsCdEJfo/3bQq0LwXblt9dO26uWe3e3YTc=; b=V7otNblMuyZJjoIlSQV8V3el9jARxmNTrT4RNaPNgCDMAs6a8ZyF72bmMx/Puc7Z4B fTlnLfxV+9FVrwnZTwLcBybPWeVSZid1maToFquae9JPCw+wLluljYJWKP0aFiHbKQ+a C7UpxYgvZORZD8n0v8Ad5ZTGd8NYrz9W4r5EUDeltqDSuoIhDJT2ZZ3wtq62iCaYQgkw uGmjfgCLmoirVbHly8G9MdrrjFWCr2LBQUiWPxfaX+zBUEguGmVOpw8Z6HYyGdad67MC 4i3mDgKKMnweBfOtBTVpeeSAgrLlGbhOY6BX9KMwPwrGxlGmX6Iz1cdceIL0DXQVChXf 618A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=toERlzzL8WsCdEJfo/3bQq0LwXblt9dO26uWe3e3YTc=; b=Ru5x2OLnHsd91bgvh2g0B0/1WOWpIaNmWXqaV1IT34cCMtQ0aDaIJJmlUmnTXZ41vT x7ztr/bJlC1I7AFnY4RiJE53/RVrsqcUiSNn2U/vVSi4Ewk/CBaUUuucKz98PFvOBCvU sKaJiRbZ90sZrVYqSteeEMZ7WQ0TyqCL6YIOTz44pgwvgVBF3AbLBh6fLEEL/c/EJom/ KarOeccMRPsdrhnT/emlPajsyQBwbNAGcM933uO/pEYv49Qko9xkl2FQ5tKpZMrdUpgL zmszBiHg0NDjBx3UhQUjVx9WNOxcPw7DsYIfuMvAb/4xl6h1o65D09cE8UEtRgT37ie6 gzkA== X-Gm-Message-State: AOAM531BlV8DzKh8MInWz5lbayfaJWrJmJUGyyYgKZ5zW0IyKBbJr0Wg TTzqjHESkG0BXsd2+G3jhas/W5fhjt9nvmkdh9xEhg== X-Google-Smtp-Source: ABdhPJzbOz34I7Z/noAxv/VgqHN/KtzJ/v+YY+qrROjrv3c/EYOpfeZxrDMfk5BeKnwQG9XwDsNMt8EnbVtsDL0qJGE= X-Received: by 2002:a19:5e5e:: with SMTP id z30mr1879264lfi.277.1605323869521; Fri, 13 Nov 2020 19:17:49 -0800 (PST) MIME-Version: 1.0 References: <47a05c5a-485d-026b-c1c3-476ed1a97856@gmail.com> <20201112123706.GA2457520@elver.google.com> <20201113103056.GA1568882@elver.google.com> <9c20815b-40df-d1c8-112f-e8d9732333eb@gmail.com> In-Reply-To: <9c20815b-40df-d1c8-112f-e8d9732333eb@gmail.com> From: David Gow Date: Sat, 14 Nov 2020 11:17:38 +0800 Message-ID: Subject: Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing To: Arpitha Raghunandan <98.arpi@gmail.com> Cc: Marco Elver , "Bird, Tim" , Brendan Higgins , Shuah Khan , Iurii Zaikin , "Theodore Ts'o" , Andreas Dilger , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , "linux-kernel-mentees@lists.linuxfoundation.org" , "linux-ext4@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 14, 2020 at 9:38 AM Arpitha Raghunandan <98.arpi@gmail.com> wrote: > > On 14/11/20 5:44 am, Marco Elver wrote: > > > > Arpitha: Do you want to send v7, but with the following modifications > > from what I proposed? Assuming nobody objects. > > > > 1. Remove the num_params counter and don't print the number of params > > anymore, nor do validation that generators are deterministic. > > 2. Remove the []. > > [ I'm happy to send as well, just let me know what you prefer. ] > > > > Thanks, > > -- Marco > > > > If no objections I will send the v7 with the above changes. > Thanks! This sounds good to me! Cheers, -- David