From: David Gow <davidgow@google.com>
To: Patricia Alfonso <trishalfonso@google.com>,
Brendan Higgins <brendanhiggins@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Andrey Konovalov <andreyknvl@google.com>,
Shuah Khan <shuah@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
KUnit Development <kunit-dev@googlegroups.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v10 3/5] KASAN: Port KASAN Tests to KUnit
Date: Tue, 4 Aug 2020 06:58:58 +0800 [thread overview]
Message-ID: <CABVgOSnpsnYw=0mAks4Xr2rGe07ER1041TKCCY1izeCfT8TcBQ@mail.gmail.com> (raw)
In-Reply-To: <20200801070924.1786166-4-davidgow@google.com>
On Sat, Aug 1, 2020 at 3:10 PM David Gow <davidgow@google.com> wrote:
>
> From: Patricia Alfonso <trishalfonso@google.com>
>
> Transfer all previous tests for KASAN to KUnit so they can be run
> more easily. Using kunit_tool, developers can run these tests with their
> other KUnit tests and see "pass" or "fail" with the appropriate KASAN
> report instead of needing to parse each KASAN report to test KASAN
> functionalities. All KASAN reports are still printed to dmesg.
>
> Stack tests do not work properly when KASAN_STACK is enabled so
> those tests use a check for "if IS_ENABLED(CONFIG_KASAN_STACK)" so they
> only run if stack instrumentation is enabled. If KASAN_STACK is not
> enabled, KUnit will print a statement to let the user know this test
> was not run with KASAN_STACK enabled.
>
> copy_user_test and kasan_rcu_uaf cannot be run in KUnit so there is a
> separate test file for those tests, which can be run as before as a
> module.
>
> Signed-off-by: Patricia Alfonso <trishalfonso@google.com>
> Signed-off-by: David Gow <davidgow@google.com>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> Reviewed-by: Andrey Konovalov <andreyknvl@google.com>
> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
> ---
> lib/Kconfig.kasan | 22 +-
> lib/Makefile | 7 +-
> lib/kasan_kunit.c | 770 ++++++++++++++++++++++++++++++++
> lib/test_kasan.c | 946 ----------------------------------------
> lib/test_kasan_module.c | 111 +++++
> 5 files changed, 902 insertions(+), 954 deletions(-)
> create mode 100644 lib/kasan_kunit.c
> delete mode 100644 lib/test_kasan.c
> create mode 100644 lib/test_kasan_module.c
Whoops -- this patch had a few nasty whitespace issues make it
through. I'll send out a new version with those fixed.
I'm pondering splitting it up to do the file rename
(test_kasan.c->kasan_kunit.c) separately as well, as git's rename
detection is not particularly happy with it.
Sorry,
-- David
next prev parent reply other threads:[~2020-08-03 22:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 7:09 [PATCH v10 0/5] KASAN-KUnit Integration David Gow
2020-08-01 7:09 ` [PATCH v10 1/5] Add KUnit Struct to Current Task David Gow
2020-08-01 7:09 ` [PATCH v10 2/5] KUnit: KASAN Integration David Gow
2020-08-01 7:09 ` [PATCH v10 3/5] KASAN: Port KASAN Tests to KUnit David Gow
2020-08-03 22:58 ` David Gow [this message]
2020-08-04 10:15 ` Andrey Konovalov
2020-08-04 23:15 ` David Gow
2020-08-01 7:09 ` [PATCH v10 4/5] KASAN: Testing Documentation David Gow
2020-08-01 7:09 ` [PATCH v10 5/5] mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set David Gow
2020-08-03 16:25 ` [PATCH v10 0/5] KASAN-KUnit Integration Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABVgOSnpsnYw=0mAks4Xr2rGe07ER1041TKCCY1izeCfT8TcBQ@mail.gmail.com' \
--to=davidgow@google.com \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=brendanhiggins@google.com \
--cc=dvyukov@google.com \
--cc=juri.lelli@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=trishalfonso@google.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).