From: Guenter Roeck <groeck@google.com>
To: Zubin Mithra <zsm@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel <linux-kernel@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] perf/pt: Annotate pt_cap_group with __ro_after_init
Date: Wed, 12 Sep 2018 09:50:16 -0700 [thread overview]
Message-ID: <CABXOdTd4iHi5=TJymRyD9c=A+=Lj2E3sFmaUzRpMJGLkk6+ZOA@mail.gmail.com> (raw)
In-Reply-To: <20180912164510.23444-1-zsm@chromium.org>
On Wed, Sep 12, 2018 at 9:45 AM Zubin Mithra <zsm@chromium.org> wrote:
>
> pt_cap_group is written to in pt_pmu_hw_init and not modified after. This makes
> it a suitable candidate for annotating as __ro_after_init.
>
> Signed-off-by: Zubin Mithra <zsm@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> arch/x86/events/intel/pt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c
> index 8d016ce5b80d..3a0aa83cbd07 100644
> --- a/arch/x86/events/intel/pt.c
> +++ b/arch/x86/events/intel/pt.c
> @@ -95,7 +95,7 @@ static ssize_t pt_cap_show(struct device *cdev,
> return snprintf(buf, PAGE_SIZE, "%x\n", pt_cap_get(cap));
> }
>
> -static struct attribute_group pt_cap_group = {
> +static struct attribute_group pt_cap_group __ro_after_init = {
> .name = "caps",
> };
>
> --
> 2.18.0.597.ga71716f1ad-goog
>
next prev parent reply other threads:[~2018-09-12 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 16:45 [PATCH] perf/pt: Annotate pt_cap_group with __ro_after_init Zubin Mithra
2018-09-12 16:50 ` Guenter Roeck [this message]
2018-09-12 21:27 ` [tip:perf/core] perf/x86/intel/pt: Annotate 'pt_cap_group' " tip-bot for Zubin Mithra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABXOdTd4iHi5=TJymRyD9c=A+=Lj2E3sFmaUzRpMJGLkk6+ZOA@mail.gmail.com' \
--to=groeck@google.com \
--cc=groeck@chromium.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zsm@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).