From: Guenter Roeck <groeck@google.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
kernel@collabora.com, Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH 04/10] platform/chrome: cros_ec_vbc: remove unused includes
Date: Tue, 8 Jan 2019 09:16:29 -0800 [thread overview]
Message-ID: <CABXOdTdbzr0GW0NPf7SQRW-ra1-GCeWNDk=vPF-w-8gZuSvqoA@mail.gmail.com> (raw)
In-Reply-To: <20190108161016.12361-5-enric.balletbo@collabora.com>
On Tue, Jan 8, 2019 at 8:10 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> None of these are required at the moment.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> drivers/platform/chrome/cros_ec_vbc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_vbc.c b/drivers/platform/chrome/cros_ec_vbc.c
> index af9bfe6f385c..86903bc31b27 100644
> --- a/drivers/platform/chrome/cros_ec_vbc.c
> +++ b/drivers/platform/chrome/cros_ec_vbc.c
> @@ -18,10 +18,8 @@
> * GNU General Public License for more details.
> */
>
> -#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/mfd/cros_ec.h>
> -#include <linux/mfd/cros_ec_commands.h>
It is customary to not rely on secondary includes. Yet, with this
removal, the code will rely on cros_ec.h including cros_ec_commands.h,
for the definition of EC_VBNV_CONTEXT_OP_READ. Does this really make
sense ?
[ I didn't check the other patches, but I suspect the same applies
there as well ]
Guenter
> #include <linux/module.h>
> #include <linux/slab.h>
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-08 17:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 16:10 [PATCH 00/10] platform/chrome: cros_ec: remove unused includes and switch to SPDX Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 01/10] platform/chrome: cros_ec_debugfs: remove unused includes Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 02/10] platform/chrome: cros_ec_lightbar: " Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 03/10] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 04/10] platform/chrome: cros_ec_vbc: " Enric Balletbo i Serra
2019-01-08 17:16 ` Guenter Roeck [this message]
2019-01-08 21:31 ` Enric Balletbo Serra
2019-01-08 16:10 ` [PATCH 05/10] platform/chrome: cros_ec_lightbar: remove pr_fmt() define Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 06/10] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 07/10] platform/chrome: cros_ec_debugfs: switch to SPDX identifier Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 08/10] platform/chrome: cros_ec_lightbar: " Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 09/10] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
2019-01-08 16:10 ` [PATCH 10/10] platform/chrome: cros_ec_vbc: " Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABXOdTdbzr0GW0NPf7SQRW-ra1-GCeWNDk=vPF-w-8gZuSvqoA@mail.gmail.com' \
--to=groeck@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).