From: Guenter Roeck <groeck@google.com>
To: Bernard Zhao <bernard@vivo.com>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Kuogee Hsieh <khsieh@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Guenter Roeck <groeck@chromium.org>,
Chandan Uddaraju <chandanu@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
opensource.kernel@vivo.com
Subject: Re: [PATCH] drm/msm: remove unneeded variable: "rc"
Date: Tue, 2 Feb 2021 08:19:14 -0800 [thread overview]
Message-ID: <CABXOdTePOqMtZ88oTNDc0TT7oH652nLHApuXkbB-44jG5Z8PAg@mail.gmail.com> (raw)
In-Reply-To: <20210202123214.15787-1-bernard@vivo.com>
On Tue, Feb 2, 2021 at 4:32 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> remove unneeded variable: "rc".
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
>
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
> index d1780bcac8cc..9cc816663668 100644
> --- a/drivers/gpu/drm/msm/dp/dp_panel.c
> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c
> @@ -409,7 +409,6 @@ int dp_panel_timing_cfg(struct dp_panel *dp_panel)
>
> int dp_panel_init_panel_info(struct dp_panel *dp_panel)
> {
> - int rc = 0;
> struct drm_display_mode *drm_mode;
>
> drm_mode = &dp_panel->dp_mode.drm_mode;
> @@ -436,7 +435,7 @@ int dp_panel_init_panel_info(struct dp_panel *dp_panel)
> min_t(u32, dp_panel->dp_mode.bpp, 30));
> DRM_DEBUG_DP("updated bpp = %d\n", dp_panel->dp_mode.bpp);
>
> - return rc;
> + return 0;
> }
>
> struct dp_panel *dp_panel_get(struct dp_panel_in *in)
> --
> 2.29.0
>
next prev parent reply other threads:[~2021-02-02 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 12:32 [PATCH] drm/msm: remove unneeded variable: "rc" Bernard Zhao
2021-02-02 16:19 ` Guenter Roeck [this message]
2021-02-02 18:21 ` Stephen Boyd
2021-03-18 3:24 [PATCH] drm/msm: Remove " zuoqilin1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXOdTePOqMtZ88oTNDc0TT7oH652nLHApuXkbB-44jG5Z8PAg@mail.gmail.com \
--to=groeck@google.com \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bernard@vivo.com \
--cc=chandanu@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=groeck@chromium.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).