* [PATCH] drm/msm: remove unneeded variable: "rc"
@ 2021-02-02 12:32 Bernard Zhao
2021-02-02 16:19 ` Guenter Roeck
2021-02-02 18:21 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Bernard Zhao @ 2021-02-02 12:32 UTC (permalink / raw)
To: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Kuogee Hsieh,
Stephen Boyd, Abhinav Kumar, Guenter Roeck, Bernard Zhao,
Chandan Uddaraju, linux-arm-msm, dri-devel, freedreno,
linux-kernel
Cc: opensource.kernel
remove unneeded variable: "rc".
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/msm/dp/dp_panel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
index d1780bcac8cc..9cc816663668 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -409,7 +409,6 @@ int dp_panel_timing_cfg(struct dp_panel *dp_panel)
int dp_panel_init_panel_info(struct dp_panel *dp_panel)
{
- int rc = 0;
struct drm_display_mode *drm_mode;
drm_mode = &dp_panel->dp_mode.drm_mode;
@@ -436,7 +435,7 @@ int dp_panel_init_panel_info(struct dp_panel *dp_panel)
min_t(u32, dp_panel->dp_mode.bpp, 30));
DRM_DEBUG_DP("updated bpp = %d\n", dp_panel->dp_mode.bpp);
- return rc;
+ return 0;
}
struct dp_panel *dp_panel_get(struct dp_panel_in *in)
--
2.29.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm: remove unneeded variable: "rc"
2021-02-02 12:32 [PATCH] drm/msm: remove unneeded variable: "rc" Bernard Zhao
@ 2021-02-02 16:19 ` Guenter Roeck
2021-02-02 18:21 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-02-02 16:19 UTC (permalink / raw)
To: Bernard Zhao
Cc: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Kuogee Hsieh,
Stephen Boyd, Abhinav Kumar, Guenter Roeck, Chandan Uddaraju,
linux-arm-msm, Maling list - DRI developers, freedreno,
linux-kernel, opensource.kernel
On Tue, Feb 2, 2021 at 4:32 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> remove unneeded variable: "rc".
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
>
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
> index d1780bcac8cc..9cc816663668 100644
> --- a/drivers/gpu/drm/msm/dp/dp_panel.c
> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c
> @@ -409,7 +409,6 @@ int dp_panel_timing_cfg(struct dp_panel *dp_panel)
>
> int dp_panel_init_panel_info(struct dp_panel *dp_panel)
> {
> - int rc = 0;
> struct drm_display_mode *drm_mode;
>
> drm_mode = &dp_panel->dp_mode.drm_mode;
> @@ -436,7 +435,7 @@ int dp_panel_init_panel_info(struct dp_panel *dp_panel)
> min_t(u32, dp_panel->dp_mode.bpp, 30));
> DRM_DEBUG_DP("updated bpp = %d\n", dp_panel->dp_mode.bpp);
>
> - return rc;
> + return 0;
> }
>
> struct dp_panel *dp_panel_get(struct dp_panel_in *in)
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm: remove unneeded variable: "rc"
2021-02-02 12:32 [PATCH] drm/msm: remove unneeded variable: "rc" Bernard Zhao
2021-02-02 16:19 ` Guenter Roeck
@ 2021-02-02 18:21 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-02-02 18:21 UTC (permalink / raw)
To: Abhinav Kumar, Bernard Zhao, Chandan Uddaraju, Daniel Vetter,
David Airlie, Guenter Roeck, Kuogee Hsieh, Rob Clark, Sean Paul,
dri-devel, freedreno, linux-arm-msm, linux-kernel
Cc: opensource.kernel
Quoting Bernard Zhao (2021-02-02 04:32:03)
> remove unneeded variable: "rc".
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/msm: Remove unneeded variable: "rc"
@ 2021-03-18 3:24 zuoqilin1
0 siblings, 0 replies; 4+ messages in thread
From: zuoqilin1 @ 2021-03-18 3:24 UTC (permalink / raw)
To: robdclark, sean, airlied, daniel
Cc: linux-arm-msm, dri-devel, linux-kernel, zuoqilin
From: zuoqilin <zuoqilin@yulong.com>
Remove unneeded variable: "rc".
Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
drivers/gpu/drm/msm/dp/dp_panel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
index 9cc8166..8cb3d01 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -351,7 +351,6 @@ void dp_panel_dump_regs(struct dp_panel *dp_panel)
int dp_panel_timing_cfg(struct dp_panel *dp_panel)
{
- int rc = 0;
u32 data, total_ver, total_hor;
struct dp_catalog *catalog;
struct dp_panel_private *panel;
@@ -404,7 +403,7 @@ int dp_panel_timing_cfg(struct dp_panel *dp_panel)
dp_catalog_panel_timing_cfg(catalog);
panel->panel_on = true;
- return rc;
+ return 0;
}
int dp_panel_init_panel_info(struct dp_panel *dp_panel)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-18 3:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 12:32 [PATCH] drm/msm: remove unneeded variable: "rc" Bernard Zhao
2021-02-02 16:19 ` Guenter Roeck
2021-02-02 18:21 ` Stephen Boyd
2021-03-18 3:24 [PATCH] drm/msm: Remove " zuoqilin1
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).