From: Guenter Roeck <groeck@google.com>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, Guenter Roeck <groeck@chromium.org>,
"Patel, Chintan M" <chintan.m.patel@intel.com>,
Jaroslav Kysela <perex@perex.cz>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files
Date: Wed, 23 May 2018 09:17:23 -0700 [thread overview]
Message-ID: <CABXOdTePWquSQaFQsoNTrVNmYydZLqF534zeoTfz0RfLDHSseA@mail.gmail.com> (raw)
In-Reply-To: <20180523155811.GO4828@sirena.org.uk>
On Wed, May 23, 2018 at 8:58 AM Mark Brown <broonie@kernel.org> wrote:
> On Wed, May 23, 2018 at 08:54:18AM -0700, Guenter Roeck wrote:
> > On Wed, May 23, 2018 at 6:56 AM Mark Brown <broonie@kernel.org> wrote:
> > > On Wed, May 23, 2018 at 03:54:54PM +0200, Takashi Iwai wrote:
> > > > And I'm wondering whether we should move these definitions to uapi
> > > > headers.
> > > Yes, we should.
> > Are you sure ? They used to be in
> > sound/soc/intel/skylake/skl-tplg-interface.h.
> > I took my clue from sound/soc/soc-topology.c, where the v4 structures
are
> > also
> > declared locally and not in the uapi files.
> I'm saying we should move them there. They're clearly part of the
> userspace ABI and therefore belong in uapi, it was a mistake to let them
> be elsewhere.
They define a firmware file format. Not sure if I would call that userspace
ABI.
I don't mind adding the structures to
sound/soc/intel/skylake/skl-tplg-interface.h,
but it seems a bit out of scope to tie this with moving the file to
include/uapi/sound.
I think that should be a separate discussion.
Thanks,
Guenter
next prev parent reply other threads:[~2018-05-23 16:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 16:58 [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files Guenter Roeck
2018-05-22 17:14 ` Mark Brown
2018-05-22 19:59 ` [alsa-devel] " Pierre-Louis Bossart
2018-05-23 8:24 ` Mark Brown
2018-05-23 13:42 ` Pierre-Louis Bossart
2018-05-23 13:56 ` Takashi Iwai
[not found] ` <CABXOdTdGyfBdZUzG-DzGgfr0Afrh9dtgdXibQreOZm7nb4z3=w@mail.gmail.com>
2018-05-23 14:58 ` Takashi Iwai
2018-05-23 15:52 ` Mark Brown
[not found] ` <CABXOdTd5+QJHOZ6BcSO-TfJCqcLzdd+Gbnf4HYh9i9cG+UH+1g@mail.gmail.com>
2018-05-23 9:49 ` Mark Brown
2018-05-23 13:54 ` Takashi Iwai
2018-05-23 13:56 ` Mark Brown
[not found] ` <CABXOdTeCr-ExO9O3XAHK-DnNf5yLGO0TPkXgs60TB90jGNB2_Q@mail.gmail.com>
2018-05-23 15:58 ` Mark Brown
2018-05-23 16:17 ` Guenter Roeck [this message]
2018-05-24 9:52 ` Takashi Iwai
2018-05-24 14:18 ` Mark Brown
2018-05-24 14:55 ` Guenter Roeck
2018-05-24 15:11 ` Mark Brown
2018-05-25 9:04 ` [alsa-devel] " Lin, Mengdong
2018-05-25 13:20 ` Guenter Roeck
2018-05-23 16:29 ` Guenter Roeck
2018-05-23 20:28 ` [alsa-devel] " Pierre-Louis Bossart
2018-05-23 21:22 ` Guenter Roeck
2018-05-24 3:38 ` Pierre-Louis Bossart
2018-05-25 13:40 ` Shreyas NC
2018-05-25 14:09 ` Guenter Roeck
2018-05-25 17:41 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXOdTePWquSQaFQsoNTrVNmYydZLqF534zeoTfz0RfLDHSseA@mail.gmail.com \
--to=groeck@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chintan.m.patel@intel.com \
--cc=groeck@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).