From: Guenter Roeck <groeck@google.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_proto: check for missing EC_CMD_HOST_EVENT_GET_WAKE_MASK
Date: Wed, 22 Jul 2020 17:54:30 -0700 [thread overview]
Message-ID: <CABXOdTedz9wRKo=3o4b6VYSi=G1-GJ7dVCv5ETdbqAa_K7yvkQ@mail.gmail.com> (raw)
In-Reply-To: <CA+ASDXPbnqRbw9EpTQ5uWt1ALh6h9dqggrEusXXaAOp46dp+Ag@mail.gmail.com>
On Wed, Jul 22, 2020 at 5:50 PM Brian Norris <briannorris@chromium.org> wrote:
>
> On Wed, Jul 22, 2020 at 5:43 PM Brian Norris <briannorris@chromium.org> wrote:
> > unless I got
> > refactor cros_ec_get_host_event_wake_mask() to use
> > cros_ec_cmd_xfer_status() instead of send_command(). I'm actually not
> > sure why we don't do that, now that I think about it...
>
> Ah, that would appear to be recursion (cros_ec_query_all() ->
> cros_ec_get_host_event_wake_mask() -> cros_ec_cmd_xfer_status() -> ...
> cros_ec_query_all()), although that could only happen if the first
> cros_ec_query_all() doesn't initialize 'proto_version' to something
> besides EC_PROTO_VERSION_UNKNOWN. That is only possible if the EC
> reports '0' back to us.
>
> I might skip out on that particular refactor for the moment.
>
Agreed, better not touch that. As for the order of changes, I agree
that they are independent. Best approach might be to submit yours, and
then we can clean up things a bit more later after my series is in the
tree.
Thanks,
Guenter
> Brian
next prev parent reply other threads:[~2020-07-23 0:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 1:57 [PATCH 1/2] platform/chrome: cros_ec_proto: ignore unnecessary wakeups on old ECs Brian Norris
2020-07-22 1:57 ` [PATCH 2/2] platform/chrome: cros_ec_proto: check for missing EC_CMD_HOST_EVENT_GET_WAKE_MASK Brian Norris
2020-07-22 10:19 ` Enric Balletbo i Serra
2020-07-22 20:50 ` Brian Norris
2020-07-22 21:13 ` Guenter Roeck
2020-07-23 0:43 ` Brian Norris
2020-07-23 0:50 ` Brian Norris
2020-07-23 0:54 ` Guenter Roeck [this message]
2020-07-23 8:08 ` Enric Balletbo i Serra
2020-07-23 8:04 ` Enric Balletbo i Serra
2020-07-24 19:39 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABXOdTedz9wRKo=3o4b6VYSi=G1-GJ7dVCv5ETdbqAa_K7yvkQ@mail.gmail.com' \
--to=groeck@google.com \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).