From: Guenter Roeck <groeck@google.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Qii Wang" <qii.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Michal Simek" <michal.simek@xilinx.com>,
linux-i2c@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-actions@lists.infradead.org
Subject: Re: [PATCH 4/5] i2c: cros-ec-tunnel: Mark ACPI and OF related data as maybe unused
Date: Sat, 11 Mar 2023 08:09:31 -0800 [thread overview]
Message-ID: <CABXOdTero=NcfJRmyOCWrt8aOVWsyEUWy0h1Y1msTmDL0VS6ew@mail.gmail.com> (raw)
In-Reply-To: <20230311111658.251951-4-krzysztof.kozlowski@linaro.org>
On Sat, Mar 11, 2023 at 3:17 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The driver can be compile tested with !CONFIG_OF or !CONFIG_ACPI making
> certain data unused:
>
> drivers/i2c/busses/i2c-cros-ec-tunnel.c:295:34: error: ‘cros_ec_i2c_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index 4e787dc709f9..8b3ff5bb14d8 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -292,13 +292,13 @@ static int ec_i2c_remove(struct platform_device *dev)
> return 0;
> }
>
> -static const struct of_device_id cros_ec_i2c_of_match[] = {
> +static const struct of_device_id cros_ec_i2c_of_match[] __maybe_unused = {
> { .compatible = "google,cros-ec-i2c-tunnel" },
> {},
> };
> MODULE_DEVICE_TABLE(of, cros_ec_i2c_of_match);
>
> -static const struct acpi_device_id cros_ec_i2c_tunnel_acpi_id[] = {
> +static const struct acpi_device_id cros_ec_i2c_tunnel_acpi_id[] __maybe_unused = {
> { "GOOG0012", 0 },
> { }
> };
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-03-11 16:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 11:16 [PATCH 1/5] i2c: mt65xx: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-11 11:16 ` [PATCH 2/5] i2c: owl: " Krzysztof Kozlowski
2023-03-11 16:05 ` Guenter Roeck
2023-03-16 19:56 ` Wolfram Sang
2023-03-11 11:16 ` [PATCH 3/5] i2c: xiic: hide OF related data for COMPILE_TEST Krzysztof Kozlowski
2023-03-11 16:34 ` Guenter Roeck
2023-03-29 18:56 ` Wolfram Sang
2023-03-11 11:16 ` [PATCH 4/5] i2c: cros-ec-tunnel: Mark ACPI and OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 16:09 ` Guenter Roeck [this message]
2023-03-16 19:56 ` Wolfram Sang
2023-03-11 11:16 ` [PATCH 5/5] i2c: synquacer: mark " Krzysztof Kozlowski
2023-03-11 16:35 ` Guenter Roeck
2023-03-29 18:56 ` Wolfram Sang
2023-03-11 16:04 ` [PATCH 1/5] i2c: mt65xx: drop of_match_ptr for ID table Guenter Roeck
2023-03-13 8:47 ` AngeloGioacchino Del Regno
2023-03-16 19:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABXOdTero=NcfJRmyOCWrt8aOVWsyEUWy0h1Y1msTmDL0VS6ew@mail.gmail.com' \
--to=groeck@google.com \
--cc=afaerber@suse.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ardb@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=qii.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).