linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <groeck@google.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Guenter Roeck <groeck@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>,
	kernel@collabora.com, Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH v2 07/12] platform/chrome: cros_ec_lpc: switch to SPDX identifier
Date: Mon, 28 Jan 2019 11:33:29 -0800	[thread overview]
Message-ID: <CABXOdTfUAsHttpy5RL861OEmjP-Cxhs_jJ_DbjssN17tbJ0Nzg@mail.gmail.com> (raw)
In-Reply-To: <20190126095131.4756-8-enric.balletbo@collabora.com>

On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also remove the license boiler-plate and redundant driver
> description.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>
> Changes in v2: None
>
>  drivers/platform/chrome/cros_ec_lpc.c     | 34 ++++++++---------------
>  drivers/platform/chrome/cros_ec_lpc_mec.c | 26 +++--------------
>  drivers/platform/chrome/cros_ec_lpc_mec.h | 20 ++-----------
>  drivers/platform/chrome/cros_ec_lpc_reg.c | 26 +++--------------
>  drivers/platform/chrome/cros_ec_lpc_reg.h | 20 ++-----------
>  5 files changed, 24 insertions(+), 102 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index 14684a56e40f..c9c240fbe7c6 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -1,25 +1,15 @@
> -/*
> - * cros_ec_lpc - LPC access to the Chrome OS Embedded Controller
> - *
> - * Copyright (C) 2012-2015 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi).  The EC does debouncing,
> - * but everything else (including deghosting) is done here.  The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// LPC interface for ChromeOS Embedded Controller
> +//
> +// Copyright (C) 2012-2015 Google, Inc
> +//
> +// This driver uses the ChromeOS EC byte-level message-based protocol for
> +// communicating the keyboard state (which keys are pressed) from a keyboard EC
> +// to the AP over some bus (such as i2c, lpc, spi).  The EC does debouncing,
> +// but everything else (including deghosting) is done here.  The main
> +// motivation for this is to keep the EC firmware as simple as possible, since
> +// it cannot be easily upgraded and EC flash/IRAM space is relatively
> +// expensive.
>
>  #include <linux/acpi.h>
>  #include <linux/dmi.h>
> diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.c b/drivers/platform/chrome/cros_ec_lpc_mec.c
> index c4edfa83e493..296554a82b83 100644
> --- a/drivers/platform/chrome/cros_ec_lpc_mec.c
> +++ b/drivers/platform/chrome/cros_ec_lpc_mec.c
> @@ -1,25 +1,7 @@
> -/*
> - * cros_ec_lpc_mec - LPC variant I/O for Microchip EC
> - *
> - * Copyright (C) 2016 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi).  The EC does debouncing,
> - * but everything else (including deghosting) is done here.  The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// LPC variant I/O for Microchip EC
> +//
> +// Copyright (C) 2016 Google, Inc
>
>  #include <linux/delay.h>
>  #include <linux/io.h>
> diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.h b/drivers/platform/chrome/cros_ec_lpc_mec.h
> index 105068c0e919..68b381f2eb50 100644
> --- a/drivers/platform/chrome/cros_ec_lpc_mec.h
> +++ b/drivers/platform/chrome/cros_ec_lpc_mec.h
> @@ -1,24 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
> - * cros_ec_lpc_mec - LPC variant I/O for Microchip EC
> + * LPC variant I/O for Microchip EC
>   *
>   * Copyright (C) 2016 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi).  The EC does debouncing,
> - * but everything else (including deghosting) is done here.  The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
>   */
>
>  #ifndef __CROS_EC_LPC_MEC_H
> diff --git a/drivers/platform/chrome/cros_ec_lpc_reg.c b/drivers/platform/chrome/cros_ec_lpc_reg.c
> index fc23d535c404..72fc3f6bff90 100644
> --- a/drivers/platform/chrome/cros_ec_lpc_reg.c
> +++ b/drivers/platform/chrome/cros_ec_lpc_reg.c
> @@ -1,25 +1,7 @@
> -/*
> - * cros_ec_lpc_reg - LPC access to the Chrome OS Embedded Controller
> - *
> - * Copyright (C) 2016 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi).  The EC does debouncing,
> - * but everything else (including deghosting) is done here.  The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// LPC interface for ChromeOS Embedded Controller
> +//
> +// Copyright (C) 2016 Google, Inc
>
>  #include <linux/io.h>
>  #include <linux/mfd/cros_ec.h>
> diff --git a/drivers/platform/chrome/cros_ec_lpc_reg.h b/drivers/platform/chrome/cros_ec_lpc_reg.h
> index 1c12c38b306a..416fd2572182 100644
> --- a/drivers/platform/chrome/cros_ec_lpc_reg.h
> +++ b/drivers/platform/chrome/cros_ec_lpc_reg.h
> @@ -1,24 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
> - * cros_ec_lpc_reg - LPC access to the Chrome OS Embedded Controller
> + * LPC interface for ChromeOS Embedded Controller
>   *
>   * Copyright (C) 2016 Google, Inc
> - *
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * This driver uses the Chrome OS EC byte-level message-based protocol for
> - * communicating the keyboard state (which keys are pressed) from a keyboard EC
> - * to the AP over some bus (such as i2c, lpc, spi).  The EC does debouncing,
> - * but everything else (including deghosting) is done here.  The main
> - * motivation for this is to keep the EC firmware as simple as possible, since
> - * it cannot be easily upgraded and EC flash/IRAM space is relatively
> - * expensive.
>   */
>
>  #ifndef __CROS_EC_LPC_REG_H
> --
> 2.20.1
>

  reply	other threads:[~2019-01-28 19:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26  9:51 [PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup Enric Balletbo i Serra
2019-01-26  9:51 ` [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier Enric Balletbo i Serra
2019-01-28 19:28   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 02/12] platform/chrome: cros_ec_debugfs: " Enric Balletbo i Serra
2019-01-28 19:28   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 03/12] platform/chrome: cros_ec_lightbar: " Enric Balletbo i Serra
2019-01-28 19:29   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 04/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
2019-01-28 19:29   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 05/12] platform/chrome: cros_ec_vbc: " Enric Balletbo i Serra
2019-01-28 19:30   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 06/12] platform/chrome: cros_ec_i2c: " Enric Balletbo i Serra
2019-01-28 19:31   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 07/12] platform/chrome: cros_ec_lpc: " Enric Balletbo i Serra
2019-01-28 19:33   ` Guenter Roeck [this message]
2019-01-26  9:51 ` [PATCH v2 08/12] platform/chrome: cros_ec_proto: " Enric Balletbo i Serra
2019-01-28 19:33   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 09/12] platform/chrome: cros_ec_spi: " Enric Balletbo i Serra
2019-01-28 19:34   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 10/12] platform/chrome: cros_kbd_led_backlight: " Enric Balletbo i Serra
2019-01-28 19:35   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define Enric Balletbo i Serra
2019-01-28 19:36   ` Guenter Roeck
2019-01-26  9:51 ` [PATCH v2 12/12] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
2019-01-28 19:36   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABXOdTfUAsHttpy5RL861OEmjP-Cxhs_jJ_DbjssN17tbJ0Nzg@mail.gmail.com \
    --to=groeck@google.com \
    --cc=bleung@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).