From: Guenter Roeck <groeck@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Gwendal Grignou <gwendal@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-iio@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] iio: cros_ec_sensors_core: signedness bug in cros_ec_sensors_read_lpc()
Date: Thu, 10 Nov 2016 12:43:21 -0800 [thread overview]
Message-ID: <CABXOdTfXKmSFvH69hgCsONUZCmdOVrjSSpzO=Br2GcD-EVyPbA@mail.gmail.com> (raw)
In-Reply-To: <20161110193957.GA18347@mwanda>
Hi Dan,
On Thu, Nov 10, 2016 at 11:39 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> "status" is a u8 so checking for negatives doesn't work. We can just
> use "ret" here instead.
>
> Fixes: 974e6f02e27e ("iio: cros_ec_sensors_core: Add common functions for the ChromeOS EC Sensor Hub.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Also fixed with https://lkml.org/lkml/2016/11/9/807
Guenter
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> index a3be799..416cae5 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> @@ -291,15 +291,15 @@ int cros_ec_sensors_read_lpc(struct iio_dev *indio_dev,
> return -EIO;
>
> /* Read status byte until EC is not busy. */
> - status = cros_ec_sensors_read_until_not_busy(st);
> - if (status < 0)
> - return status;
> + ret = cros_ec_sensors_read_until_not_busy(st);
> + if (ret < 0)
> + return ret;
>
> /*
> * Store the current sample id so that we can compare to the
> * sample id after reading the data.
> */
> - samp_id = status & EC_MEMMAP_ACC_STATUS_SAMPLE_ID_MASK;
> + samp_id = ret & EC_MEMMAP_ACC_STATUS_SAMPLE_ID_MASK;
>
> /* Read all EC data, format it, and store it into data. */
> ret = cros_ec_sensors_read_data_unsafe(indio_dev, scan_mask,
prev parent reply other threads:[~2016-11-10 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 19:39 [patch] iio: cros_ec_sensors_core: signedness bug in cros_ec_sensors_read_lpc() Dan Carpenter
2016-11-10 20:43 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABXOdTfXKmSFvH69hgCsONUZCmdOVrjSSpzO=Br2GcD-EVyPbA@mail.gmail.com' \
--to=groeck@google.com \
--cc=dan.carpenter@oracle.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).