From: Guenter Roeck <groeck@google.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
"Jason M ." <jason@montleon.com>
Subject: Re: [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB
Date: Fri, 6 Aug 2021 08:04:18 -0700 [thread overview]
Message-ID: <CABXOdTfXzdJE0Nye-rttp50cnTJy-nU9RcFxkONDo3hXvVWDUA@mail.gmail.com> (raw)
In-Reply-To: <20210806130227.69473-1-andriy.shevchenko@linux.intel.com>
Trying again, text only this time. Sorry for the trouble.
On Fri, Aug 6, 2021 at 6:08 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE
> can't be built-in.
>
> Fixes: 53067471188c ("iio / platform: cros_ec: Add cros-ec-sensorhub driver")
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979
> Reported-by: Jason M. <jason@montleon.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iio/common/cros_ec_sensors/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/cros_ec_sensors/Kconfig b/drivers/iio/common/cros_ec_sensors/Kconfig
> index fefad9572790..b0d67ceaed55 100644
> --- a/drivers/iio/common/cros_ec_sensors/Kconfig
> +++ b/drivers/iio/common/cros_ec_sensors/Kconfig
> @@ -4,7 +4,8 @@
> #
> config IIO_CROS_EC_SENSORS_CORE
> tristate "ChromeOS EC Sensors Core"
> - depends on SYSFS && CROS_EC_SENSORHUB
> + depends on CROS_EC_SENSORHUB=y || (CROS_EC_SENSORHUB=m && m)
> + depends on SYSFS
This seems wrong. IIO_CROS_EC_SENSORS_CORE should already be limited to m
if CROS_EC_SENSORHUB=m.
Note that I can not reproduce the problem in the bugzilla entry,
neither with mainline
nor with v5.13.6. And the configuration file published there looks fine and
already has IIO_CROS_EC_SENSORS_CORE=m.
Guenter
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
> --
> 2.30.2
>
prev parent reply other threads:[~2021-08-06 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 13:02 [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB Andy Shevchenko
2021-08-06 13:31 ` Andy Shevchenko
2021-08-06 15:04 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXOdTfXzdJE0Nye-rttp50cnTJy-nU9RcFxkONDo3hXvVWDUA@mail.gmail.com \
--to=groeck@google.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=jason@montleon.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).