From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE16C4332F for ; Fri, 18 Nov 2022 23:10:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234836AbiKRXK5 (ORCPT ); Fri, 18 Nov 2022 18:10:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235327AbiKRXKe (ORCPT ); Fri, 18 Nov 2022 18:10:34 -0500 Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65AAF52149 for ; Fri, 18 Nov 2022 14:56:12 -0800 (PST) Received: by mail-vs1-xe30.google.com with SMTP id d185so6186263vsd.0 for ; Fri, 18 Nov 2022 14:56:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UmKsoJxhwH4Zh+3ZRgMkGn8gHiF62zNOvvsc+BHVWu8=; b=gv5F7ldhqfhIsH8rj3kBab8j3pSGRlztT61uH5evDl+HD5sgZtbydI6mpzpUVuzG8w YxQXSM6U8nVYzRJVQKm7Ef/Kq8/0ykjLifVJZvy5lZxJpUnT68gXHvyT+AfjHJ8ss63h fg36VGWZ4unUYwmA1GNCLHmzGCV9c9ZhCPoCp9p2IBaOIFkxcwqSK1MwPat+bRDUwt81 NWo540av9xzkf4Y2CYpuUGM7d5GSWhMxR8KvQ4euz7RoF87hnX9CqCsIveMPn7tfq8Ms luYfJv3E9eCXO9HoCcu8z+dRooFHGSnqf/CwwXE7ORqCQKnnc+O08v/oxgxCpfa8ffFE W3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UmKsoJxhwH4Zh+3ZRgMkGn8gHiF62zNOvvsc+BHVWu8=; b=4o4YSL1PwMwegMvK1B/VIT7wuvTvWm2YqrSvb0AENDaIPT7VOrHNp+GhN2lN44GIBT btJKYufpqDWppVnb9e0C422q94vPg/IVxFSan7Agcvv9aWreyJVvk6jJx6s156KbyePa SvKBTZbCuJOS8x4pIGVYLqs8Jv5XsYKyHKsWSh5WdrMnrple+h3XiMgh14j7RxmZdDWw JSOnRdn1F23ZCr1brBvPP4v0MPGEspVSGu3r8HWhIW96vbYzoOn4/DliUgmz9bHmkTXX GOw455Dly1hkJ3jqs7XZvD+bMkS0xRWerG52TmiUfC4eh1r56FQyFrvuYyTzsqeGHQdp 3HFg== X-Gm-Message-State: ANoB5plxRCoCxpfbw5dN+1ZppKi2gmiZ4m0elna9mv/oEZTYB2TtjUua 4HIqscVHGO5F8EECwjjNOrHwzLmPjCb4C/YxC8e8qQ== X-Google-Smtp-Source: AA0mqf4qDmbgKxpR2oFN7ECgll96czI8S2WtEpfjmw8jRjheJPJwoxDQZr632xe+zCiiTlcR9Xb4LznOsV0wW5aR7/c= X-Received: by 2002:a05:6102:502:b0:3ad:94ed:2ab5 with SMTP id l2-20020a056102050200b003ad94ed2ab5mr5590845vsa.45.1668812143450; Fri, 18 Nov 2022 14:55:43 -0800 (PST) MIME-Version: 1.0 References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-513-uwe@kleine-koenig.org> In-Reply-To: <20221118224540.619276-513-uwe@kleine-koenig.org> From: Guenter Roeck Date: Fri, 18 Nov 2022 14:55:32 -0800 Message-ID: Subject: Re: [PATCH 512/606] platform/chrome: cros_ec: Convert to i2c's .probe_new() To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Benson Leung , linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 2:48 PM Uwe Kleine-K=C3=B6nig wrote: > > From: Uwe Kleine-K=C3=B6nig > > The probe function doesn't make use of the i2c_device_id * parameter so i= t > can be trivially converted. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Guenter Roeck > --- > drivers/platform/chrome/cros_ec_i2c.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_i2c.c b/drivers/platform/chr= ome/cros_ec_i2c.c > index b6823c654c3f..dbe698f33128 100644 > --- a/drivers/platform/chrome/cros_ec_i2c.c > +++ b/drivers/platform/chrome/cros_ec_i2c.c > @@ -286,8 +286,7 @@ static int cros_ec_cmd_xfer_i2c(struct cros_ec_device= *ec_dev, > return ret; > } > > -static int cros_ec_i2c_probe(struct i2c_client *client, > - const struct i2c_device_id *dev_id) > +static int cros_ec_i2c_probe(struct i2c_client *client) > { > struct device *dev =3D &client->dev; > struct cros_ec_device *ec_dev =3D NULL; > @@ -373,7 +372,7 @@ static struct i2c_driver cros_ec_driver =3D { > .of_match_table =3D of_match_ptr(cros_ec_i2c_of_match), > .pm =3D &cros_ec_i2c_pm_ops, > }, > - .probe =3D cros_ec_i2c_probe, > + .probe_new =3D cros_ec_i2c_probe, > .remove =3D cros_ec_i2c_remove, > .id_table =3D cros_ec_i2c_id, > }; > -- > 2.38.1 >