From: ethan zhao <ethan.kernel@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Kurt Garloff <kurt@garloff.de>, Len Brown <len.brown@intel.com>
Subject: ACPI and NUMA guys, please help to check if this patch is OK
Date: Wed, 23 May 2012 10:46:09 +0800 [thread overview]
Message-ID: <CABawtvNSYENtrJTaB5Vfd+j5MahE=xv4Ueb6-zmd1CHShuU0iQ@mail.gmail.com> (raw)
[PATCH] drivers/acpi/numa.c: Add localities checking code against
proximity domains to slit_valid()
Some buggy BIOS/ACPI will set different number to SLIT localities and
SRAT proximity domains,
That will make NUMA configuration invalid and kernel will output
information like following
NUMA:Warning:invalid distance parameter, from=-1 to=-1 distance=83
This patch adds some checking code to slit_valid() function in order
to check theSLIT localities
count against SRAT proximity domains number and give clear information
about ACPI bug.
Signed-off-by: ethan.zhao <ethan.kernel@gmail.com>
---
drivers/acpi/numa.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
index e56f3be..55c8a8e 100644
--- a/drivers/acpi/numa.c
+++ b/drivers/acpi/numa.c
@@ -161,6 +161,13 @@ static __init int slit_valid(struct acpi_table_slit *slit)
{
int i, j;
int d = slit->locality_count;
+ int pxd = nodes_weight(nodes_found_map);
+ if (pxd != d) {
+ printk(KERN_INFO "ACPI: BIOS bug! SLIT localities
count %d doesn't equal SRAT proximity domains number %d\n",
+ d , pxd);
+ return 0;
+ }
+
for (i = 0; i < d; i++) {
for (j = 0; j < d; j++) {
u8 val = slit->entry[d*i + j];
--
1.7.1
next reply other threads:[~2012-05-23 2:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 2:46 ethan zhao [this message]
2012-05-23 3:30 ` ACPI and NUMA guys, please help to check if this patch is OK David Rientjes
2012-05-24 3:08 ` ethan zhao
2012-05-24 4:45 ` David Rientjes
[not found] ` <CABawtvMtO5NR-j3zX2xxXfgZ_XxrCdF+k+n4jG3KyEVe=xYjjA@mail.gmail.com>
2012-11-13 8:12 ` Ethan Zhao
2012-11-13 8:27 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABawtvNSYENtrJTaB5Vfd+j5MahE=xv4Ueb6-zmd1CHShuU0iQ@mail.gmail.com' \
--to=ethan.kernel@gmail.com \
--cc=kurt@garloff.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).