From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752636AbdK0WJs (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 17:09:48 -0500
Received: from mail-io0-f195.google.com ([209.85.223.195]:34572 "EHLO
        mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751835AbdK0WJq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 17:09:46 -0500
X-Google-Smtp-Source: AGs4zMbkT0UygawXUvSIW1rZcLjnp/IvaKtWw8F2yudIVBRmlFDdcpTJ6GzUFmqohbXY9M3jJP2YwGUxkhzVYYNqHKU=
MIME-Version: 1.0
In-Reply-To: <510cf2fb-1d53-485f-bfd1-3d852378c866@redhat.com>
References: <1511714482-3273-1-git-send-email-sironi@amazon.de>
 <1511714482-3273-2-git-send-email-sironi@amazon.de> <510cf2fb-1d53-485f-bfd1-3d852378c866@redhat.com>
From: Steve Rutherford <srutherford@google.com>
Date: Mon, 27 Nov 2017 14:09:05 -0800
Message-ID: <CABayD+dirdj9k=y=yKKJos+Wp-Yh91aO8RJwqMP-1UP54qD3+w@mail.gmail.com>
Subject: Re: [PATCH 2/2] KVM: x86: Allow userspace to define what's the
 microcode version
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Filippo Sironi <sironi@amazon.de>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        KVM list <kvm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 27, 2017 at 3:58 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 26/11/2017 17:41, Filippo Sironi wrote:
>> ... that the guest should see.
>> Guest operating systems may check the microcode version to decide whether
>> to disable certain features that are known to be buggy up to certain
>> microcode versions.  Address the issue by making the microcode version
>> that the guest should see settable.
>> The rationale for having userspace specifying the microcode version, rather
>> than having the kernel picking it, is to ensure consistency for live-migrated
>> instances; we don't want them to see a microcode version increase without a
>> reset.
>>
>> Signed-off-by: Filippo Sironi <sironi@amazon.de>
>> ---
>>  arch/x86/kvm/x86.c       | 23 +++++++++++++++++++++++
>>  include/uapi/linux/kvm.h |  3 +++
>>  2 files changed, 26 insertions(+)
>>
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index 925c3e29cad3..741588f27ebc 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -4033,6 +4033,29 @@ long kvm_arch_vm_ioctl(struct file *filp,
>>       } u;
>>
>>       switch (ioctl) {
>> +     case KVM_GET_MICROCODE_VERSION: {
>> +             r = -EFAULT;
>> +             if (copy_to_user(argp,
>> +                              &kvm->arch.microcode_version,
>> +                              sizeof(kvm->arch.microcode_version)))
>> +                     goto out;
>> +             break;
>> +     }
>> +     case KVM_SET_MICROCODE_VERSION: {
>> +             u32 microcode_version;
>> +
>> +             r = -EFAULT;
>> +             if (copy_from_user(&microcode_version,
>> +                                argp,
>> +                                sizeof(microcode_version)))
>> +                     goto out;
>> +             r = -EINVAL;
>> +             if (!microcode_version)
>> +                     goto out;
>> +             kvm->arch.microcode_version = microcode_version;
>> +             r = 0;
>> +             break;
>> +     }
>
> Also, there's no need to define new ioctls, instead you can just place
> it in the vcpu and use KVM_GET_MSR/KVM_SET_MSR.  I'd agree that's
> slightly less polished, but it matches what we do already for e.g.
> nested VMX model specific registers.  And it spares you for writing the
> documentation that you didn't include in this patch. :)
>
> Paolo

This feels good time to mention Peter Hornyack's old MSR KVM_EXIT
patches. With something like them, there would be no need to push this
into the kernel at all.