From: Jassi Brar <jassisinghbrar@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Tushar Khandelwal <Tushar.Khandelwal@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Morten Borup Petersen <morten_bp@live.dk>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Usama Arif <usama.arif@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mailbox: arm_mhuv2: Add driver
Date: Thu, 12 Nov 2020 19:34:49 -0600 [thread overview]
Message-ID: <CABb+yY1LH_3TdD4uLc297VOiuEkarWh5p4ZF2qDmbo1B0uH+dw@mail.gmail.com> (raw)
In-Reply-To: <20201111060226.cbq4pmwtrt7s2weq@vireshk-i7>
On Wed, Nov 11, 2020 at 12:02 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 27-10-20, 17:23, Viresh Kumar wrote:
> > This adds driver for the ARM MHUv2 (Message Handling Unit) mailbox
> > controller.
> >
> > This is based on the accepted DT bindings of the controller and supports
> > combination of all transport protocols, i.e. single-word, multi-word and
> > doorbell.
> >
> > Transmitting and receiving data through the mailbox framework in
> > multi-word mode is done through struct arm_mhuv2_mbox_msg. Rest of the
> > implementation details can be seen in the bindings document or in the
> > driver itself.
> >
> > Based on the initial work done by Morten Borup Petersen from ARM.
> >
> > Co-developed-by: Tushar Khandelwal <tushar.khandelwal@arm.com>
> > Signed-off-by: Tushar Khandelwal <tushar.khandelwal@arm.com>
> > Tested-by: Usama Arif <usama.arif@arm.com>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > Bindings are already reviewed by Rob and are present here:
> >
> > http://lore.kernel.org/lkml/61ca14fc441f92c1e7994e5bebae5c49811a3050.1602563406.git.viresh.kumar@linaro.org
>
> Jassi, Any inputs on this ?
>
Can we make 'single-word' as a special case of 'multi-word', i.e,
effect single-word by specifying 1 sized multi-word.
And the names of structs and members could be lower case? It seems
very firmware style, or is it just me?
cheers.
prev parent reply other threads:[~2020-11-13 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 11:53 [PATCH] mailbox: arm_mhuv2: Add driver Viresh Kumar
2020-11-11 6:02 ` Viresh Kumar
2020-11-13 1:34 ` Jassi Brar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABb+yY1LH_3TdD4uLc297VOiuEkarWh5p4ZF2qDmbo1B0uH+dw@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=Sudeep.Holla@arm.com \
--cc=Tushar.Khandelwal@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morten_bp@live.dk \
--cc=robh+dt@kernel.org \
--cc=usama.arif@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).