From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC4FC4361B for ; Tue, 15 Dec 2020 21:22:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6997822CB8 for ; Tue, 15 Dec 2020 21:22:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728428AbgLOVWI (ORCPT ); Tue, 15 Dec 2020 16:22:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727582AbgLOVVq (ORCPT ); Tue, 15 Dec 2020 16:21:46 -0500 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00EEFC06179C for ; Tue, 15 Dec 2020 13:21:06 -0800 (PST) Received: by mail-pl1-x643.google.com with SMTP id 4so11729345plk.5 for ; Tue, 15 Dec 2020 13:21:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jQbmRDJKcfm0nMG1Zrd5hG96AtVHrMVfiJzxnIRuJBE=; b=U1xMu5odAzE/9Jg085hDsQCrdy6XrNPQ3lX/aTSgwjzP4MaJO61XUEoqvOC1ptacGa M+4R6IzfGxOXtAobgqXDJnZiXyJBNWKF2UUglf5PHm9vtiwPyBjljtJYD9iYaRqIi4DC 9GijZhQGUFSe4NEKots2QjX7axwTWdwROMHRJFsMplAxxtEIlGeM63MIjrB4U3bU7UkC tsOv68GQEz/2k8Abew/EYxgiejU7ph3rEwGlTwYS+4g8LSxqNW8QxxJUCy6Z470LmjZP 8pKQrwkCXIr4lFd6Ul7cBi4m4C2+SsHLDtJ+OXCP79FDT2TJ2tmm2nISXViKSNT1JB6e JJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jQbmRDJKcfm0nMG1Zrd5hG96AtVHrMVfiJzxnIRuJBE=; b=uYQp/EDwuxpbk6gLepBAukx5t9FfHUKCcr4ThbxPYlZj3r9UKXcIKhCBMr9Al8zvz0 8cGPYCHv720TGtKRl8qkovsXCHhm1FwstG8FzXI8wLdV3elGgcXzGGObAW2S3i1xloAD P780/U0RvOPc4pTgUgJN4KXklXKU2ZBIuS1VWAGYO7IjMIGUaSd/Y0jAAOvZ5+T6+GK3 XkU6dpyGJerqjkOCcLTnwjETP2r0zf1gKgdACZqebiuXe+Y0LtAX0jyqqNxHSWRqiwPW irqLvORqrYNtUoRWkM7OiBr+vbwJJwV21GVionPYBYzwksfIltG+cq2V55vYTa94xOrd RL7Q== X-Gm-Message-State: AOAM531gMl+2sl+jC9KjLpSY4U2QWcu5hOiVaZET0hhFEmXs22DmhFzH 2WXi+V7YQ6952r3mbJSuXyG/qZSmF9Oj2zNoHs0= X-Google-Smtp-Source: ABdhPJymE3tSWJEbkSF97ixTf4/XyFkA/sxBlPvb73SK/66sqLlpUS0xPZkSB6JmCqjfDpw0gI1DIP2lq29uR8XAtlo= X-Received: by 2002:a17:902:ee11:b029:db:c0d6:581a with SMTP id z17-20020a170902ee11b02900dbc0d6581amr29211163plb.54.1608067265568; Tue, 15 Dec 2020 13:21:05 -0800 (PST) MIME-Version: 1.0 References: <1608022118-29993-1-git-send-email-yaohaidong369@gmail.com> In-Reply-To: <1608022118-29993-1-git-send-email-yaohaidong369@gmail.com> From: Jassi Brar Date: Tue, 15 Dec 2020 15:20:54 -0600 Message-ID: Subject: Re: [PATCH] add chan->cl check in mbox_chan_received_data() To: Haidong Yao Cc: natechancellor@gmail.com, ndesaulniers@google.com, Linux Kernel Mailing List , clang-built-linux@googlegroups.com, Orson Zhai , Chunyan Zhang , Haidong Yao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2020 at 2:48 AM Haidong Yao wrote: > --- a/drivers/mailbox/mailbox.c > +++ b/drivers/mailbox/mailbox.c > @@ -152,7 +152,7 @@ static enum hrtimer_restart txdone_hrtimer(struct hrtimer *hrtimer) > void mbox_chan_received_data(struct mbox_chan *chan, void *mssg) > { > /* No buffering the received data */ > - if (chan->cl->rx_callback) > + if (chan->cl && chan->cl->rx_callback) > chan->cl->rx_callback(chan->cl, mssg); > } The proper fix is in the controller driver. Which should stop tx/rx when the channel is freed. thnx.