From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbcGGE15 (ORCPT ); Thu, 7 Jul 2016 00:27:57 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:34196 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750697AbcGGE1z (ORCPT ); Thu, 7 Jul 2016 00:27:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <1466503374-28841-1-git-send-email-narmstrong@baylibre.com> <1466503374-28841-2-git-send-email-narmstrong@baylibre.com> From: Jassi Brar Date: Thu, 7 Jul 2016 09:57:48 +0530 Message-ID: Subject: Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit To: Neil Armstrong Cc: "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , Sudeep Holla , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Frank Wang , Kevin Hilman , "open list:ARM/Amlogic Meson..." , Caesar Wang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 6, 2016 at 6:47 PM, Neil Armstrong wrote: > 2016-07-04 17:38 GMT+02:00 Jassi Brar : >> On Tue, Jun 21, 2016 at 3:32 PM, Neil Armstrong wrote: >>> Add Amlogic Meson SoCs Message-Handling-Unit as mailbox controller >>> with 2 independent channels/links to communicate with a remote processor. >>> >>> Signed-off-by: Neil Armstrong >>> --- >>> drivers/mailbox/Makefile | 2 + >>> drivers/mailbox/meson_mhu.c | 199 ++++++++++++++++++++++++++++++++++++++++++++ >>> >> Can we call it pdev_mhu.c or similar so that some other platform using >> the MHU as a platform_device wouldn't have to embarrassingly call it >> 'Meson's MHU'? And also the replace meson with that prefix in the >> code. > > Yes, it may deserve a more generic naming, but pdev_mhu is not good > looking at all ! > What about platform_mhu ? > OK