linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Tushar Khandelwal <Tushar.Khandelwal@arm.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Sudeep Holla <Sudeep.Holla@arm.com>,
	Morten Borup Petersen <morten_bp@live.dk>,
	Usama Arif <usama.arif@arm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5 2/2] mailbox: arm_mhuv2: Add driver
Date: Fri, 20 Nov 2020 13:06:52 -0600	[thread overview]
Message-ID: <CABb+yY2mhUPbigeYo+ZirFP0z1n0wKPP46VOtsBmbZQmWB=jAA@mail.gmail.com> (raw)
In-Reply-To: <180854d3b40b779ea989dfa18154431f70011c18.1605607138.git.viresh.kumar@linaro.org>

On Tue, Nov 17, 2020 at 4:02 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:

> +
> +/**
> + * struct mhuv2 - MHUv2 mailbox controller data
> + *
> + * @mbox:      Mailbox controller belonging to the MHU frame.
> + * @send/recv: Base address of the register mapping region.
> + * @frame:     Frame type: RECEIVER_FRAME or SENDER_FRAME.
> + * @irq:       Interrupt.
> + * @windows:   Channel windows implemented by the platform.
> + * @minor:     Minor version of the controller.
> + * @length:    Length of the protocols array in bytes.
> + * @protocols: Raw protocol information, derived from device tree.
> + * @doorbell_pending_lock: spinlock required for correct operation of Tx
> + *             interrupt for doorbells.
> + */
> +struct mhuv2 {
> +       struct mbox_controller mbox;
> +       union {
> +               struct mhu2_send_frame_reg __iomem *send;
> +               struct mhu2_recv_frame_reg __iomem *recv;
> +       };
> +       enum mhuv2_frame frame;
> +       unsigned int irq;
> +       unsigned int windows;
> +       unsigned int minor;
> +       unsigned int length;
> +       u32 *protocols;
> +
> +       spinlock_t doorbell_pending_lock;
>
Can you please explain the need of this lock? Some usecase?
It should be unnecessary if the controller natively supports doorbell mode.

thanks.

  reply	other threads:[~2020-11-20 19:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 10:02 [PATCH V5 0/2] mailbox: Add mhuv2 mailbox controller's support Viresh Kumar
2020-11-17 10:02 ` [PATCH V5 1/2] dt-bindings: mailbox : arm,mhuv2: Add bindings Viresh Kumar
2020-11-17 10:02 ` [PATCH V5 2/2] mailbox: arm_mhuv2: Add driver Viresh Kumar
2020-11-20 19:06   ` Jassi Brar [this message]
2020-11-23  6:49     ` Viresh Kumar
2020-12-09  7:24 ` [PATCH V5 0/2] mailbox: Add mhuv2 mailbox controller's support Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABb+yY2mhUPbigeYo+ZirFP0z1n0wKPP46VOtsBmbZQmWB=jAA@mail.gmail.com' \
    --to=jassisinghbrar@gmail.com \
    --cc=Sudeep.Holla@arm.com \
    --cc=Tushar.Khandelwal@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=morten_bp@live.dk \
    --cc=robh@kernel.org \
    --cc=usama.arif@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --subject='Re: [PATCH V5 2/2] mailbox: arm_mhuv2: Add driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).